Remove orphaned scripts / makefile #356
Conversation
|
I've still been using the Makefile to call regression, but could set that up differently. |
|
Oh, and I have been using the top level Makefile not the one in starcheck/data/Makefile. The one you suggest removing seems fine to go. |
|
Since we are still using the agasc.bad list made with bad_stars.py I don't know if we want to remove the script (and manual_bad_stars) until we swap to using the agasc supplement (which I suppose we could do at any point, I was just headed to doing it more via #327 ). |
|
I think of |
|
The driver of course being that |
|
I already removed agasc.bad in the sparkles branch I think, because I was letting sparkles do the bad star tests from the agasc supplement. My point about maybe waiting and removing together was that bad_stars.py at least can tell you why a star is in the current list. |
|
I really don't think we care at this point, and it's going to all be overtaken by mag-stats. |
|
OK. Then this PR could remove the manual stars file and the sausage one too. |
|
Done, removed those two. |
Description
Neither of the two scripts are called anywhere and bad_stars.py apparently hasn't been run in 5 years. This is all overtaken by improvements in mica (bad obsid list and mag stats). The bad_stars script relies on an unmaintained sybase table.
The Makefile just seems a leftover from another era, but not 100% sure.
This came up in working on removing Sybase dependencies.
Testing