WIP: Call sparkles from starcheck #327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
commented
Sep 8, 2020
| converted by de_bytestr early in this method. | ||
|
|
||
| :param kwargs: dict of expected keywords | ||
| :return tuple: (list of floats of star acq probabilties, float P2, float expected acq stars) |
jeanconn
commented
Sep 8, 2020
|
|
1 task
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call sparkles from starcheck
The idea is that this could be could be a simple way to mostly call one set of checks on catalogs. The next steps in this PR would be to cut out the starcheck checks that duplicate sparkles checks. And then in this PR we need to document how the removed checks are replaced in sparkles. Probably also need to update review_aca_checks to read the sparkles checks.