More shiny fixes #231
More shiny fixes #231
Conversation
|
Does this pass tests as a user without sybase access? |
|
Good question. I think the logic I put in for the sybase stuff is moving in the right direction, but I suppose I can try tests as kadi user on linux and see if I get the right skips and expected warns. |
cfdfed0 to
6e32a8e
Compare
6e32a8e to
3b32e11
Compare
|
So stringifying the fid id seems to be the only thing needed to pass tests. The changes to remove the "jeanconn" business look to me like they work to add new warnings if the tests are being run on head either in an environment that isn't set up for sybase or as a user who doesn't have axafvv database access. Passes test as 'kadi' user with and without SYBASE set, appropriately skips the report test but adds a warning. I think the warning is appropriate for my use cases but if we want to, say, pull the report-writing test into something separate to run as a "long" test we could do that. We could also ask for 'aca' user to have 'axafvv' read access and Javier is going to need it too. |
Description
Fix V&V handling of missing fid in shiny (also works in ska3-flight).
Also set code to assume USER to run the axafvv queries so the V&V report making can work as user other than 'jeanconn'.
Set report writing test to work as USER as well and provide new warnings on Linux if the axafvv database access doesn't work.
Testing
Fixes #228, #179, #152