8000 Shiny by jeanconn · Pull Request #230 · sot/mica · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Shiny #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Shiny #230

merged 6 commits into from
Aug 10, 2020

Conversation

jeanconn
Copy link
Contributor
@jeanconn jeanconn commented Aug 7, 2020

Description

Shiny.

I wasn't paying enough attention and ended up duplicating most of this work because there was no PR. None of these updates seem to require shiny anyway? -Jean

Testing

  • Passes unit tests on Linux ska3-flight (and shiny except for VV test fixed in More shiny fixes #231)
  • Functional testing not required

Fixes half of #228

@taldcroft
Copy link
Member

Sorry about the stealth shiny branch.

@jeanconn
Copy link
Contributor Author
jeanconn commented Aug 8, 2020

No sweat on stealth. I appreciate the progress in all forms. And I still haven't addressed the super-slow-tests issue but the commits I pushed to the end of this PR seemed non-controversial and of the same type.

@taldcroft taldcroft merged commit 09a9c4c into master Aug 10, 2020
@taldcroft taldcroft deleted the shiny branch August 10, 2020 14:58
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0