Add tests for file-table-json, bump sorbet-typed #3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
approved these changes
Jun 11, 2020
|
Thanks for adding that test case, it looks like the snapshot tests just need to be updated as the |
vilhena-stripe
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Add test for empty file-table-json * sto //gems/sorbet/test/snapshot:update * Add another test * Change test runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This basically adds tests to ensure we don't regress #3168.
Test plan
See included automated tests.