8000 Fix master failure (JSON parse error in srb init) by jez · Pull Request #3168 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix master failure (JSON parse error in srb init) #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix master failure (JSON parse error in srb init) #3168

merged 1 commit into from
Jun 9, 2020

Conversation

jez
Copy link
Collaborator
@jez jez commented Jun 9, 2020

Motivation

Master is failing after a change to sorbet-typed

Test plan

I will follow up with some more tests later today, but the fact that this build
passes when other branch builds and master are failing should be evidence
enough.

@jez jez requested a review from a team as a code owner June 9, 2020 17:53
@jez jez requested review from elliottt and removed request for a team June 9, 2020 17:53
@jez jez force-pushed the jez-fix-master branch from 3c440c4 to 7220383 Compare June 9, 2020 18:28
@jez jez merged commit e273eb6 into master Jun 9, 2020
@jez jez deleted the jez-fix-master branch June 9, 2020 18:43
@jez jez mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

@DarkDimius DarkDimius DarkDimius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jez @elliottt @DarkDimius
0