IDE: Cleaner LSPTypechecker::retypecheck() interface. #2304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisamanra
approved these changes
Dec 6, 2019
main/lsp/LSPTypechecker.cc
Outdated
|
|
||
| TypecheckRun LSPTypechecker::retypecheck(vector<core::FileRef> frefs) const { | ||
| LSPFileUpdates updates = getNoopUpdate(move(frefs)); | ||
| auto workers = WorkerPool::create(0, *config->logger); |
There was a problem hiding this comment.
I think this is the only line I'm slightly confused about, but I also don't pretend to understand the WorkerPool abstraction. Does this do something side-effecting? Because otherwise it looks like it's unused.
There was a problem hiding this comment.
embarrassed look
I copied this code from my preemptive slow path changes. It's unused and has no side effects. I'll remove it prior to merging. Thanks for catching!
There was a problem hiding this comment.
Removed. I also switched to using indexed directly instead of getIndexed since I don't want indexedFinalGS trees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE: Cleaner LSPTypechecker::retypecheck() interface. Code actions use this to get a list of errors from a file and extract autocorrects from those errors.
Motivation
This implementation bothered me, so I decided to quickly clean it up.
Test plan
Covered by existing code_action tests.