8000 Convert core::File::Type to an enum class by jez · Pull Request #2417 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Convert core::File::Type to an enum class #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Convert core::File::Type to an enum class #2417

merged 1 commit into from
Jan 4, 2020

Conversation

jez
Copy link
Collaborator
@jez jez commented Jan 3, 2020 •
edited
Loading

Motivation

See #2403

Test plan

See included automated tests.

@jez jez requested a review from a team January 3, 2020 23:19
@jez jez merged commit a72eeeb into master Jan 4, 2020
@jez jez deleted the jez-file-enum-class branch January 4, 2020 00:18
@ghost ghost requested review from aisamanra and removed request for a team January 4, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkDimius DarkDimius DarkDimius approved these changes

@aisamanra aisamanra Awaiting requested review from aisamanra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @DarkDimius
0