10000 Implement realnum::rand by Mec-iS · Pull Request #251 · smartcorelib/smartcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement realnum::rand #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
Mar 20, 2023
Merged

Implement realnum::rand #251

merged 84 commits into from
Mar 20, 2023

Conversation

Mec-iS
Copy link
Collaborator
@Mec-iS Mec-iS commented Mar 20, 2023

Implement rand. Use the new derive [#default]

Fixes #214

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

realnum::rand returns 1.0

New expected behaviour

random number is generated

dependabot-preview bot and others added 30 commits November 8, 2022 11:29
* build(deps): update nalgebra requirement from 0.23.0 to 0.26.2

Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version.
- [Release notes](https://github.com/dimforge/nalgebra/releases)
- [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md)
- [Commits](dimforge/nalgebra@v0.23.0...v0.26.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix: updates for nalgebre

* test: explicitly call pow_mut from BaseVector since now it conflicts with nalgebra implementation

* Don't be strict with dependencies

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version.
- [Release notes](https://github.com/dimforge/nalgebra/releases)
- [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md)
- [Commits](dimforge/nalgebra@v0.23.0...v0.31.0)

---
updated-dependencies:
- dependency-name: nalgebra
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* initial fastpair implementation
* FastPair initial implementation
* implement fastpair
* Add random test
* Add bench for fastpair
* Refactor with constructor for FastPair
* Add serialization for PairwiseDistance
* Add fp_bench feature for fastpair bench
* Add example

* Move to top

* Add imports to example

* Fix imports
* docs: Fix typo in doc for categorical transformer.
* feat: Add option to take a column from Matrix.
I created the method `Matrix::take_column` that uses the `Matrix::take`-interface to extract a single column from a matrix. I need that feature in the implementation of  `StandardScaler`.
* feat: Add `StandardScaler`.
Authored-by: titoeb <timtoebrock@googlemail.com>
* Derive `serde::Serialize` and `serde::Deserialize` for
  `StandardScaler`.
* Add relevant unit test.

Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>
* Update criterion requirement from 0.3 to 0.4

Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version.
- [Release notes](https://github.com/bheisler/criterion.rs/releases)
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.3.0...0.4.0)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix criterion

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* handle multiclass precision/recall
* grid search draft
* hyperparam search for linear estimators
* feat: Add interface to build `Matrix` from rows.
* feat: Add option to derive `RealNumber` from string.
To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string.
* feat: Implement `Matrix::read_csv`.
…#160)

* fix: fix compilation warnings when running only with default features
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
#159)

* feat: allocate first and then proceed to create matrix from Vec of RowVectors
* grid search draft

* hyperparam search for linear estimators

* grid search for ensembles

* support grid search for more algos

* grid search for unsupervised algos

* minor cleanup
* Provide better output in flaky tests

* feat: add seed parameter to multiple algorithms

* Update changelog

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* add seed param to search params

* make default params available to serde

* lints

* create defaults for enums

* lint
* feat: expose hyper tuning module in model_selection

* Move to a folder

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Mec-iS and others added 9 commits November 8, 2022 11:29
* Fixes for release
* add new test
* Remove change applied in development branch
* Only add dependency for wasm32
* Update ci.yml

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
* Handle kernel serialization
* Do not use typetag in WASM
* enable tests for serialization
* Update serde feature deps

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
@Mec-iS Mec-iS requested a review from morenol March 20, 2023 13:14
@codecov-commenter
Copy link
codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #251 (c5ccce9) into development (7d059c4) will increase coverage by 0.08%.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff               @@
##           development     #251      +/-   ##
===============================================
+ Coverage        44.36%   44.44%   +0.08%     
===============================================
  Files               85       85              
  Lines             7220     7218       -2     
===============================================
+ Hits              3203     3208       +5     
+ Misses            4017     4010       -7     
Impacted Files Coverage Δ
src/algorithm/neighbour/mod.rs 42.85% <ø> (+2.85%) ⬆️
src/linear/logistic_regression.rs 38.34% <ø> (+0.19%) ⬆️
src/linear/ridge_regression.rs 41.22% <ø> (+0.35%) ⬆️
src/neighbors/mod.rs 100.00% <ø> (+16.66%) ⬆️
src/tree/decision_tree_classifier.rs 50.57% <0.00%> (+0.19%) ⬆️
src/numbers/realnum.rs 40.90% <50.00%> (+10.90%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Mar 20, 2023

thanks @morenol
I need a 0.3.1 release asap! 👍🏼

@morenol
Copy link
Collaborator
morenol commented Mar 20, 2023

thanks @morenol I need a 0.3.1 release asap! 👍🏼

Can you bump the version on this PR?

morenol
morenol previously approved these changes Mar 20, 2023
Copy link
Collaborator
@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure why ignore was added to one of the doc tests

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Mar 20, 2023

LGTM but not sure why ignore was added to one of the doc tests

that test uses datasets feature so it fails, it is replicated among the tests with the right flag.

I may have more changes in the next hours, I am adding anti-panicking checks to fit methods.

@morenol
Copy link
Collaborator
morenol commented Mar 20, 2023

I may have more changes in the next hours, I am adding anti-panicking checks to fit methods.

I like that idea!

@morenol
Copy link
Collaborator
morenol commented Mar 20, 2023

It seems that there is conflicts, it says to me that there are 83 commits on this PR, could you rebase?

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Mar 20, 2023

It seems that there is conflicts, it says to me that there are 83 commits on this PR, could you rebase?

that is because I pushed the wrong branch at the creation of the PR, then I corrected it.
Check in "Files Changed" that the changes are only the latest ones.

EDIT: your local branch may be missing the "Update README.md" I pushed before this PR.

@Mec-iS Mec-iS merged commit f498f96 into development Mar 20, 2023
@Mec-iS Mec-iS deleted the implement-rand branch March 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomness: implementation and use getrandom for Wasm target
9 participants
0