8000 fix: fix issue with iterator for svc search by morenol · Pull Request #182 · smartcorelib/smartcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix issue with iterator for svc search #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2022
Merged

fix: fix issue with iterator for svc search #182

merged 1 commit into from
Oct 2, 2022

Conversation

morenol
Copy link
Collaborator
@morenol morenol commented Oct 2, 2022 •
edited
Loading

There is an issue with the iterator for SVC Search'

&& self.current_seed == self.svc_search_parameters.kernel.len()

should be

            && self.current_seed == self.svc_search_parameters.seed.len()

@morenol morenol requested a review from Mec-iS as a code owner October 2, 2022 00:26
@morenol morenol requested a review from montanalow October 2, 2022 00:26
@codecov-commenter
Copy link
codecov-commenter commented Oct 2, 2022 •
edited
Loading

Codecov Report

Merging #182 (e1f9346) into development (f8210d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #182      +/-   ##
===============================================
+ Coverage        84.58%   84.60%   +0.01%     
===============================================
  Files               86       86              
  Lines             9974     9973       -1     
===============================================
+ Hits              8437     8438       +1     
+ Misses            1537     1535       -2
Impacted Files Coverage Δ
src/svm/svc.rs 87.93% <100.00%> (+0.22%) ⬆️
src/optimization/line_search.rs 92.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@morenol morenol merged commit 12df301 into smartcorelib:development Oct 2, 2022
@morenol morenol deleted the lmm/fix_typo branch October 2, 2022 11:40
morenol added a commit that referenced this pull request Nov 8, 2022
@morenol
fix: fix issue with iterator for svc search (#182)
d520007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mec-iS Mec-iS Mec-iS approved these changes

@montanalow montanalow Awaiting requested review from montanalow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morenol @codecov-commenter @Mec-iS
0