8000 Ready for Release 0.3.0 by Mec-iS · Pull Request #236 · smartcorelib/smartcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ready for Release 0.3.0 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 81 commits into from
Nov 8, 2022
Merged

Ready for Release 0.3.0 #236

merged 81 commits into from
Nov 8, 2022

Conversation

Mec-iS
Copy link
Collaborator
@Mec-iS Mec-iS commented Nov 8, 2022

merge to main

dependabot-preview bot and others added 30 commits May 11, 2022 13:04
* build(deps): update nalgebra requirement from 0.23.0 to 0.26.2

Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version.
- [Release notes](https://github.com/dimforge/nalgebra/releases)
- [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md)
- [Commits](dimforge/nalgebra@v0.23.0...v0.26.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix: updates for nalgebre

* test: explicitly call pow_mut from BaseVector since now it conflicts with nalgebra implementation

* Don't be strict with dependencies

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version.
- [Release notes](https://github.com/dimforge/nalgebra/releases)
- [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md)
- [Commits](dimforge/nalgebra@v0.23.0...v0.31.0)

---
updated-dependencies:
- dependency-name: nalgebra
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* initial fastpair implementation
* FastPair initial implementation
* implement fastpair
* Add random test
* Add bench for fastpair
* Refactor with constructor for FastPair
* Add serialization for PairwiseDistance
* Add fp_bench feature for fastpair bench
* Add example

* Move to top

* Add imports to example

* Fix imports
* docs: Fix typo in doc for categorical transformer.
* feat: Add option to take a column from Matrix.
I created the method `Matrix::take_column` that uses the `Matrix::take`-interface to extract a single column from a matrix. I need that feature in the implementation of  `StandardScaler`.
* feat: Add `StandardScaler`.
Authored-by: titoeb <timtoebrock@googlemail.com>
* Derive `serde::Serialize` and `serde::Deserialize` for
  `StandardScaler`.
* Add relevant unit test.

Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>
* Update criterion requirement from 0.3 to 0.4

Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version.
- [Release notes](https://github.com/bheisler/criterion.rs/releases)
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.3.0...0.4.0)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix criterion

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* handle multiclass precision/recall
* grid search draft
* hyperparam search for linear estimators
* feat: Add interface to build `Matrix` from rows.
* feat: Add option to derive `RealNumber` from string.
To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string.
* feat: Implement `Matrix::read_csv`.
…#160)

* fix: fix compilation warnings when running only with default features
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
#159)

* feat: allocate first and then proceed to create matrix from Vec of RowVectors
* grid search draft

* hyperparam search for linear estimators

* grid search for ensembles

* support grid search for more algos

* grid search for unsupervised algos

* minor cleanup
* Provide better output in flaky tests

* feat: add seed parameter to multiple algorithms

* Update changelog

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* add seed param to search params

* make default params available to serde

* lints

* create defaults for enums

* lint
* feat: expose hyper tuning module in model_selection

* Move to a folder

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@morenol
Copy link
Collaborator
morenol commented Nov 8, 2022

@Mec-iS I think that we should fix some issues with getrandom in wasm32 when we want to target non-browser targets

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Nov 8, 2022

ok. which issues, please be specific.

@morenol
Copy link
Collaborator
morenol commented Nov 8, 2022

cargo build --target wasm32-unknown-unknown should compile with success without the need to enable the js (for non browser targets) and use js for browser targets. I think that we should keep using rand instead of getrandom

@morenol
6855
Copy link
Collaborator
morenol commented Nov 8, 2022

Also, should we merge #232 before release?

@Mec-iS Mec-iS requested a review from morenol November 8, 2022 15:45
* Fixes for release
* add new test
* Remove change applied in development branch
* Only add dependency for wasm32
* Update ci.yml

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
morenol
morenol previously approved these changes Nov 8, 2022
Copy link
Collaborator
@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for leading all the effort to accomplish this. Other than maybe merging this first, #232 it looks good to me

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Nov 8, 2022

thanks to you. we merge 232 first

@codecov-commenter
Copy link

Codecov Report

Merging #236 (9eaae9e) into main (70df9a8) will decrease coverage by 39.44%.
The diff coverage is 48.46%.

@@             Coverage Diff             @@
##             main     #236       +/-   ##
===========================================
- Coverage   83.42%   43.97%   -39.45%     
===========================================
  Files          78       85        +7     
  Lines        8362     7281     -1081     
===========================================
- Hits         6976     3202     -3774     
- Misses       1386     4079     +2693     
1084E
Impacted Files Coverage Δ
src/algorithm/neighbour/mod.rs 46.66% <0.00%> (-31.91%) ⬇️
src/algorithm/sort/heap_select.rs 42.85% <ø> (-54.88%) ⬇️
src/algorithm/sort/quick_sort.rs 58.10% <ø> (-27.08%) ⬇️
src/dataset/boston.rs 83.33% <ø> (-10.00%) ⬇️
src/dataset/digits.rs 83.33% <ø> (-8.98%) ⬇️
src/dataset/mod.rs 32.14% <0.00%> (-38.23%) ⬇️
src/error/mod.rs 33.33% <0.00%> (-14.67%) ⬇️
src/linalg/traits/high_order.rs 0.00% <ø> (ø)
src/metrics/accuracy.rs 46.15% <ø> (-37.18%) ⬇️
src/metrics/auc.rs 50.00% <ø> (-44.74%) ⬇️
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Handle kernel serialization
* Do not use typetag in WASM
* enable tests for serialization
* Update serde feature deps

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
@morenol
Copy link
Collaborator
morenol commented Nov 8, 2022

Not sure if we should squash and merge this, maybe rebase directly into that branch?

@Mec-iS
Copy link
Collaborator Author
Mec-iS commented Nov 8, 2022

ok, add the approval and proceed to the merge as you see fit.

@morenol morenol merged commit 62de25b into main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0