Add extendedAddress Sample Data (#4397) #4441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added extendedAddress to examples.txt
Added extendedAddress to examples.txt.net
Added extendedAddress to examples.txt
|
I think that is the location? I would look at past PRs for evidence of examples appearing in schema.org? I wonder if it would be better to not update existing examples of address usage and instead add a specific new example of extended address usage? |
|
I feel it's a very common field that never found it's way here because someone skipped a line while reading an IETF standard some 15 years ago, but being a chronical line skipper myself I align with you :) |
|
@gmackenz I think your european colleagues are all out on vacation due to the long weekend 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sample data for extendedAddress added in #4402 .
@rrlevering @gmackenz I am unsure where to put sample data as neither of the sample files seems to be versioned or anything. I took a large approach. Could you check if I understood it correctly?
Tests seem to run correctly, but I am unsure of the correct approach here.