8000 Add extendedAddress to Address (concerns #4397) by fthobe · Pull Request #4402 · schemaorg/schemaorg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add extendedAddress to Address (concerns #4397) #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Add extendedAddress to Address (concerns #4397) #4402

merged 1 commit into from
Apr 16, 2025

Conversation

fthobe
Copy link
Contributor
@fthobe fthobe commented Apr 11, 2025 •
edited
Loading

Aligning the address with a second Address line as discussed in #4397.

Concerns also #75

@fthobe
Copy link
Contributor Author
fthobe commented Apr 11, 2025

@rrlevering here you go.

@fthobe
Copy link
Contributor Author
fthobe commented Apr 15, 2025

@rrlevering can we pass that given the precedent in vcard and related address standards?

rrlevering
rrlevering requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@rrlevering rrlevering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

"appartment" -> "apartment" and probably "CO" -> "c/o"

What does "alternative name" mean?

@fthobe
Add extendedAddress to Address (concerns schemaorg#4397)
e040587 
Aligning the address with a second Address line as discussed in schemaorg#4397.
@fthobe fthobe force-pushed the extended-address branch from eb0711b to e040587 Compare April 16, 2025 00:34
@fthobe
Copy link
Contributor Author
fthobe commented Apr 16, 2025 •
edited
Loading

@rrlevering should be fine now.

"appartment" -> "apartment"

Sorry, my italian heritage got the better of me.

probably "CO" -> "c/o"

I made the change, anything to consider regarding escaping of any characters in TTL files?

What does "alternative name" mean?

We run flagship stores for consumer electronic brands. Our company name does not neccessarily coincide with the name of the store.
vCard standard says the following in RFC 6350 (Section 6.3.1:

the extended address (e.g., apartment or suite number);

I thought that's a little reductive.

@rrlevering rrlevering merged commit 4ebbab6 into schemaorg:main Apr 16, 2025
1 check passed
@fthobe fthobe deleted the extended-address branch April 18, 2025 18:54
@fthobe fthobe mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrlevering rrlevering rrlevering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fthobe @rrlevering
0