check base to decide whether singular supports the ring #39112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 20531f3; changes) is ready! 🎉 |
|
On the long term, I feel it's better to change the whole thing to EAFP instead of LBYL. The current "check before convert" system has a massive issue that when Singular implements something upstream we won't know to change it. Or if one part of the code implement it, other part won't benefit from it. That's the plan, but easier said than done. Maybe I'll take a look after #39075 is done (sound like there will be a lot of merge conflicts otherwise) |
|
I agree completely! I would think that, currently, we actually do the work almost twice, right? Once for checking and once for actually converting. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-39112: check base to decide whether singular supports the ring For fraction fields, we also have to check whether the base is a polynomial ring. Fixes sagemath#39106 URL: sagemath#39112 Reported by: Martin Rubey Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fraction fields, we also have to check whether the base is a polynomial ring.
Fixes #39106