8000 Add cfg(test) to line domain impl by andrewmilson · Pull Request #969 · starkware-libs/stwo-cairo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add cfg(test) to line domain impl #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cfg(test) to line domain impl #969

wants to merge 1 commit into from
+13 −7

Conversation

andrewmilson
Copy link
Contributor
@andrewmilson andrewmilson commented Jun 3, 2025 •
edited by RoeiE-starkware
Loading

This change is Reviewable

This was referenced Jun 3, 2025
Merged
Merged
@andrewmilson Graphite App
Copy link
Contributor Author
andrewmilson commented Jun 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewmilson andrewmilson marked this pull request as ready for review June 3, 2025 03:08
@andrewmilson andrewmilson force-pushed the 06-02-add_cfg_test_to_line_domain_impl branch from c8d6456 to a601d70 Compare June 3, 2025 03:46
This was referenced Jun 3, 2025
Open
Open
@andrewmilson andrewmilson force-pushed the 06-02-add_cfg_test_to_line_domain_impl branch from a601d70 to 42238dd Compare June 3, 2025 14:33
shaharsamocha7
shaharsamocha7 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator
@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson changed the base branch from 06-02-use_lookup_table_for_bit_mask to graphite-base/969 June 16, 2025 12:26
@andrewmilson andrewmilson force-pushed the 06-02-add_cfg_test_to_line_domain_impl branch from 42238dd to 4ff9084 Compare June 16, 2025 12:28
@andrewmilson andrewmilson changed the base branch from graphite-base/969 to 06-02-use_lookup_table_for_bit_mask June 16, 2025 12:28
@andrewmilson andrewmilson changed the base branch from 06-02-use_lookup_table_for_bit_mask to graphite-base/969 June 16, 2025 12:51
@andrewmilson andrewmilson force-pushed the 06-02-add_cfg_test_to_line_domain_impl branch from 4ff9084 to 953d23a Compare June 16, 2025 13:35
@andrewmilson andrewmilson changed the base branch from graphite-base/969 to main June 16, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharsamocha7 shaharsamocha7 shaharsamocha7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
0