8000 Use lookup table for bit mask by andrewmilson · Pull Request #968 · starkware-libs/stwo-cairo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use lookup table for bit mask #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Use lookup table for bit mask #968

merged 1 commit into from
Jun 16, 2025

Conversation

andrewmilson
Copy link
Contributor
@andrewmilson andrewmilson commented Jun 3, 2025 •
edited by RoeiE-starkware
Loading

This change is Reviewable

@andrewmilson andrewmilson mentioned this pull request Jun 3, 2025
Merged
@andrewmilson Graphite App
Copy link
Contributor Author
andrewmilson commented Jun 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewmilson andrewmilson mentioned this pull request Jun 3, 2025
Merged
@andrewmilson andrewmilson marked this pull request as ready for review June 3, 2025 03:08
@andrewmilson andrewmilson mentioned this pull request Jun 3, 2025
Merged
@andrewmilson andrewmilson force-pushed the 06-02-use_lookup_table_for_bit_mask branch from a2f6713 to 38208e7 Compare June 3, 2025 14:33
@andrewmilson andrewmilson mentioned this pull request Jun 3, 2025
Open
shaharsamocha7
shaharsamocha7 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator
@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

shaharsamocha7
shaharsamocha7 requested changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator
@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

stwo_cairo_verifier/crates/verifier_core/src/utils.cairo line 185 at r2 (raw file):

    const BIT_MASKS: [u64; 65] = [
        0b0, //
        0b1, //

what's that?

Code quote:

·

@andrewmilson andrewmilson changed the base branch from 06-02-remove_sort_and_dedup_from_verifier to graphite-base/968 June 16, 2025 12:25
@andrewmilson andrewmilson force-pushed the 06-02-use_lookup_table_for_bit_mask branch from 38208e7 to d07fa95 Compare June 16, 2025 12:27
@andrewmilson andrewmilson changed the base branch from graphite-base/968 to 06-02-remove_sort_and_dedup_from_verifier June 16, 2025 12:27
andrewmilson
andrewmilson commented Jun 16, 2025
View reviewed changes
Copy link
Contributor Author
@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

stwo_cairo_verifier/crates/verifier_core/src/utils.cairo line 185 at r2 (raw file):

Previously, shaharsamocha7 wrote…

what's that?

Done.

shaharsamocha7
shaharsamocha7 approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator
@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

Base automatically changed from 06-02-remove_sort_and_dedup_from_verifier to main June 16, 2025 12:51
@andrewmilson andrewmilson changed the base branch from main to graphite-base/968 June 16, 2025 12:51
@andrewmilson andrewmilson force-pushed the 06-02-use_lookup_table_for_bit_mask branch from d07fa95 to 51d304b Compare June 16, 2025 12:51
@andrewmilson andrewmilson changed the base branch from graphite-base/968 to main June 16, 2025 12:51
@andrewmilson andrewmilson merged commit 7c928cc into main Jun 16, 2025
13 checks passed
@andrewmilson andrewmilson deleted the 06-02-use_lookup_table_for_bit_mask branch June 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharsamocha7 shaharsamocha7 shaharsamocha7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewmilson @shaharsamocha7
0