8000 add geoparquet/arrow drivers for GDAL by cboettig · Pull Request #633 · rocker-org/rocker-versioned2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add geoparquet/arrow drivers for GDAL #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 21, 2023
Merged

add geoparquet/arrow drivers for GDAL #633

merged 12 commits into from
Apr 21, 2023

Conversation

cboettig
Copy link
Member

No description provided.

@cboettig cboettig marked this pull request as ready for review April 19, 2023 03:36
@cboettig cboettig requested a review from eitsupi April 19, 2023 03:36
@cboettig
Copy link
Member Author

@eitsupi can you take a look over this when you get a chance?

Apologies about the linter error, not quite sure what is up there. I'm basically following the syntax from the official arrow installation instructions, though I'm not quite clear why they have gone about this by using wget + a .deb file install in order to update sources.list.d dir rather than the traditional PPA route...

@cboettig
Copy link
Member Author

@mdsumner would you mind taking a look over this updated gdal build recipe?

eitsupi
eitsupi reviewed Apr 19, 2023
View reviewed changes
eitsupi
eitsupi reviewed Apr 19, 2023
View reviewed changes
@eitsupi eitsupi closed this Apr 19, 2023
@eitsupi eitsupi reopened this Apr 19, 2023
@eitsupi
Copy link
Member
eitsupi commented Apr 19, 2023

(I closed and reopened it once to trigger CI)

eitsupi
eitsupi reviewed Apr 19, 2023
View reviewed changes
eitsupi
eitsupi reviewed Apr 19, 2023
View reviewed changes
eitsupi
eitsupi reviewed Apr 19, 2023
View reviewed changes
@cboettig
Copy link
Member Author

❤️ Thanks so much for the help here @eitsupi, looks great! If you're ok with the NCPUS change here feel free to merge when ready.

eitsupi
eitsupi approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member
@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallelization seems to have cut build time in half. Let's merge.

@eitsupi ei 7198 tsupi merged commit 40a67dd into master Apr 21, 2023
@eitsupi eitsupi deleted the feat/osgeo-parquet branch April 21, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cboettig @eitsupi
0