Use Pooled ByteBuffer in SpigotReflectionUtil#decodeBukkitItemStack #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master branch to a more stable build of PacketEvents.
Try to fix build by updating geyser connector
Fixed WrappedPacketLoginInEncryptionBegin for 1.19+
…going to make login success packet unsendable. (Which means packetevents plugins can't send it using our API, please update to 2.0 if you need this feature)
SystemChat relocated
* feat: add 1.19.1 version support to Client-/ & Server version * feat: added 1.19.1 support to CLIENT_VERSIONS array * feat: updated ChatPosition and added little TODO comment * feat: added `getPlayerUUID` and `setPlayerUUID` to WrappedPacketLoginInStart (still needs SignatureData) * Added minimal 1.19.1 support, only wrapper complete 1.19.1 support is PlayerInfo. Won't add the newly 1.19.1 created wrappers as this version is slowly dying Co-authored-by: retrooper <retrooperdev@gmail.com>
make WrappedPacketOutPlayerInfo#getPlayerInfo playerInfoArray big enough
fixed ArrayIndexOutOfBoundsException
|
GitHub just killed me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a pooled ByteBuf is more efficient because it avoids the overhead of allocating and deallocating ByteBufs repeatedly. It also reduces memory fragmentation and improves garbage collection efficiency.