1.19.1 Update (PE 1.8) #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InStart (still needs SignatureData)
… PlayerInfo. Won't add the newly 1.19.1 created wrappers as this version is slowly dying
|
Looking good now, very minimal 1.19.1 support to just get it working for most plugins. Be aware maintaining two versions is hard and one should look into updating to 2.0 slowly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.19.1 Update
Additions
We only add the wrappers when we want to. But since we have announced that we will no longer add new features, they will not be added if they are not needed.
Changes
ChatPositionenums for modern and legacy supportChatPositionhandling as 1.19.1 removed some types and added new onesClientLoginStartwrapper now also has aplayerUUIDfield which is nullable (due to cross versions support)ClientChatCommandandClientChatMessagewrappers now also haveLastSeenMessagesfields which are nullable (due to cross versions support)ServerChatMessagewrapper changes the plain ChatContent (first field) from a Component to a plain String with a limit of 256 charactersServerServerDatawrapper now also has aenforceSecureChat(boolean) field which is always false on legacy versionsServerSystemChatMessagewrapper needs an overhaul to support the newChatPositionenumand because 1.19.1 no longer supports overlays we need to take care of that