10000 release: v1.23.0 by PascalRepond · Pull Request #3722 · rero/rero-ils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

release: v1.23.0 #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

release: v1.23.0 #3722

merged 1 commit into from
Aug 13, 2024

Conversation

PascalRepond
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the developers From a developer point of view. label Jul 18, 2024
@PascalRepond
Copy link
Contributor Author
PascalRepond commented Jul 22, 2024 •
edited
Loading

Tests

  • [not-blocking] REP/22.07: Order line, deleting an existing note field and re-adding it -> The field is not displayed. I have to save and come back to add the note.
    • Will be fixed in next ng-core version.
  • REP/23.07: Console error in public view: "Content-Security-Policy : Les paramètres de la page ont empêché le chargement d’une ressource (font-src) à l’adresse data:image/svg+xml;base64,PHN2Zz48ZGVmcz… car elle enfreint la directive suivante : « default-src * »"
  • REP/23.07: Still no favicon in pro UI (normal?). Favicon seems random in public view, sometimes it's rero ils logo, sometimes it's the magnifier.
  • MD: not linked to the release? Public UI: can submit an ILL request without pickup location. In this case, the ILL request is not saved/added.
    • REP: I will open an issue.
  • MD: Files tab empty for the 4 locations so we cannot delete the files (ok for the newly added files). Ex: https://ilsdev.test.rero.ch/professional/records/documents/detail/208
    • REP: These files belong to another organisation.
  • MD: note display issue. TypeError: Cannot read properties of undefined (reading 'type') . Ex: try to checkout item 10000001882 to Katie.
    image

@PascalRepond PascalRepond force-pushed the rep-release branch 3 times, most recently from 1b5bcc8 to e28d448 Compare July 30, 2024 06:36
@PascalRepond PascalRepond force-pushed the rep-release branch 2 times, most recently from d849f3a to 7a454d9 Compare August 12, 2024 13:35
@PascalRepond PascalRepond marked this pull request as ready for review August 12, 2024 13:36
@PascalRepond
release: v1.23.0
d0c3f65 
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond merged commit 34cf6b5 into rero:staging Aug 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees
No one assigned
Labels
developers From a developer point of view.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PascalRepond @rerowep
0