fix(circ): error when no item note #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5eb2ca to
04bb8ac
Compare
04bb8ac to
74db974
Compare
74db974 to
f27667b
Compare
jma
approved these changes
Jul 24, 2024
* When performing a circulation action on an item that had no circulation note, `getCirculationNoteForAction()` returned [null] and this created an error when displaying the note. Now, `getCirculationNoteForAction()` only returns a note if it exists, else it return an empty array. * Also fixes some in transit alerts on checkin that was not correctly translated and was missing destination info. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
f27667b to
afbc648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCirculationNoteForAction()returned [null] and this created an error when displaying the note. Now,getCirculationNoteForAction()only returns a note if it exists, else it return an empty array.