8000 Fix modal backdrop display by iLiviu · Pull Request #112 · remotestorage/remotestorage-widget · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix modal backdrop display #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix modal backdrop display #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/assets/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,7 @@ polygon.rs-logo-shape,

.remotestorage-widget-modal-backdrop {
display: none;
z-index: 20000000;
position: absolute;
position: fixed;
top: 0;
bottom: 0;
left: 0;
Expand Down
2 changes: 2 additions & 0 deletions src/assets/widget.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<div class="remotestorage-widget-modal-backdrop"></div>

<!--
rs-state-initial
rs-state-choose
Expand Down
13 changes: 0 additions & 13 deletions src/widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,18 +174,6 @@ Widget.prototype = {
return element;
},

/**
* Create the widget's modal backdrop element, add
* styling, and append to DOM
*
* @private
*/
createBackdropHtml () {
const backdropEl = document.createElement('div');
backdropEl.classList.add('remotestorage-widget-modal-backdrop');
document.body.appendChild(backdropEl);
},

/**
* Sets the `rs-modal` class on the widget element.
* Done by default for small screens (max-width 420px).
Expand Down Expand Up @@ -270,7 +258,6 @@ Widget.prototype = {
* @param {String} [elementId] - Widget's parent
*/
attach (elementId) {
this.createBackdropHtml()
const domElement = this.createHtmlTemplate();

let parentContainerEl;
Expand Down
0