8000 Fix modal backdrop display by iLiviu · Pull Request #112 · remotestorage/remotestorage-widget · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix modal backdrop display #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix modal backdrop display #112

merged 1 commit into from
Jun 11, 2020

Conversation

iLiviu
Copy link
Member
@iLiviu iLiviu commented Jun 2, 2020

Place the modal backdrop element inside the widget container, so that even if the widget is attached to positioned elements, the modal backdrop does not display over the widget contents.

I think this approach is better to fix the problem as it does not require the developers to apply any hacks.

I should note that i don't have much experience with styling, so i don't know if placing the backdrop inside the widget can cause other display issues that i can't think of.

Fixes #109
Fixes #110

@iLiviu
Fix modal backdrop display on positioned elements
cc6938e 
Place the modal backdrop element inside the widget container,
so that even if the widget is attached to positioned elements,
the modal backdrop does not hide the widget contents.

Fixes #109
Fixes #110
@raucao
Copy link
Member
raucao commented Jun 5, 2020

This seems to work perfectly fine in my testing! Good job.

@raucao raucao mentioned this pull request Jun 5, 2020
Closed
@raucao raucao changed the title Fix modal backdrop display on positioned elements Fix modal backdrop display Jun 11, 2020
@raucao raucao merged commit 76e4c5e into master Jun 11, 2020
@raucao raucao deleted the bugfix/109_backdrop_on_mobile_devices branch June 11, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background Modal in Foreground Buggy on narrow devices.
2 participants
@iLiviu @raucao
0