8000 Skip failing polars tests by Matt711 · Pull Request #18015 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Skip failing polars tests #18015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2025
Merged

Skip failing polars tests #18015

merged 3 commits into from
Feb 15, 2025

Conversation

Matt711
Copy link
Contributor
@Matt711 Matt711 commented Feb 14, 2025

Description

These tests re failing in CI, but I'm not able to reproduce the error locally. This PR is intended to unblock CI, while I investigate.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Feb 14, 2025
@Matt711 Matt711 requested a review from a team as a code owner February 14, 2025 21:23
@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Feb 14, 2025
@mroeschke
Copy link
Contributor
mroeschke commented Feb 14, 2025 •
edited
Loading

xref pola-rs/polars#21274. It appears to be due to a polars dependency update

@galipremsagar galipremsagar requested a review from a team as a code owner February 14, 2025 22:16
@galipremsagar
Copy link
Contributor

xref pola-rs/polars#21274. It appears to be due to a polars dependency update

@Matt711 I pushed another workaround in this commit: 608436a

@jameslamb jameslamb mentioned this pull request Feb 14, 2025
Merged
3 tasks
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 14, 2025
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b82d0e7 into rapidsai:branch-25.04 Feb 15, 2025
114 checks passed
@Matt711 Matt711 mentioned this pull request Feb 19, 2025
Merged
3 tasks
raydouglass pushed a commit that referenced this pull request Feb 19, 2025
@Matt711
Skip the failing connectorx polars tests (#18037)
c99f393 
In #18015, we tried skipping the failing polars tests and applying the
workaround mentioned in polars issue 21274. But pip is [unable to solve
our test
environment](https://github.com/rapidsai/cudf/actions/runs/13406947992/job/37463788766)
in that case. This PR just skips the tests because we only need to do
one or the other, not both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

@galipremsagar galipremsagar

@Matt711 Matt711

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt711 @mroeschke @galipremsagar @vyasr
0