8000 consolidate more conda solves in CI by jameslamb · Pull Request #18014 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

consolidate more conda solves in CI #18014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 15, 2025
Merged

consolidate more conda solves in CI #18014

merged 6 commits into from
Feb 15, 2025

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#22

Follow-up to #17995

  • ensures all of the conda solves in CI are consolidated
  • ensures the locally-downloaded files are considered in conda solves

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2025
@jameslamb jameslamb requested review from a team as code owners February 14, 2025 16:21
jameslamb
jameslamb commented Feb 14, 2025
View reviewed changes
ci/test_python_common.sh
@@ -20,6 +18,8 @@ FILE_KEY=$1
rapids-dependency-file-generator \
--output conda \
--file-key "${FILE_KEY}" \
--prepend-channel "${CPP_CHANNEL}" \
--prepend-channel "${PYTHON_CHANNEL}" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these channels missing was the cause of what we observed in #17994 (comment), where it looks like the recently-built-in-CI packages were being ignored in favor of older packages from the rapidsai-nightly channel.

jameslamb
jameslamb commented Feb 14, 2025
View reviewed changes
dependencies.yaml
packages:
- libcudf-example==25.4.*,>=0.0.0a0
- libcudf_kafka==25.4.*,>=0.0.0a0
- libcudf-tests==25.4.*,>=0.0.0a0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking here that we don't need depends_on groups for each of these, given they're only referenced in one place.

Previous discussions @bdice and I had about that:

@jameslamb jameslamb mentioned this pull request Feb 14, 2025
Open
KyleFromNVIDIA
KyleFromNVIDIA requested changes Feb 14, 2025
View reviewed changes
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Feb 14, 2025
Closed
19 tasks
KyleFromNVIDIA
KyleFromNVIDIA requested changes Feb 14, 2025
View reviewed changes
@davidwendt
Copy link
Contributor

Looks like a CLI parameter issue in test_java.sh
https://github.com/rapidsai/cudf/actions/runs/13333751036/job/37245897114?pr=18014

jameslamb
jameslamb commented Feb 14, 2025
View reviewed changes
@jameslamb
Copy link
Member Author

Sorry about that! Fixed in the most recent commit. And pulled in latest branch-25.04... might as well test on an up-to-date branch if we need a full CI re-run anyway.

@jameslamb jameslamb mentioned this pull request Feb 14, 2025
Merged
@jameslamb
Copy link
Member Author

Seeing this in polars tests:

FAILED py-polars/tests/unit/io/database/test_read.py::test_read_database[uri: connectorx] - ValueError: arrow2
FAILED py-polars/tests/unit/io/database/test_read.py::test_read_database_cx_credentials[fakedb:/123:456@account/database/schema?warehouse=warehouse&role=role] - ValueError: arrow2
FAILED py-polars/tests/unit/io/database/test_read.py::test_read_database_cx_credentials[fakedb:/my#%us3r:p433w0rd@not_a_real_host:9999/database] - ValueError: arrow2
= 3 failed, 14746 passed, 27 skipped, 58 deselected, 140 xfailed in 520.59s (0:08:40) =

(build link)

Those are unrelated and should be resolved by #18015

@Matt711 Matt711 mentioned this pull request Feb 15, 2025
Merged
3 tasks
@Matt711
Copy link
Contributor
Matt711 commented Feb 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit e497a1e into rapidsai:branch-25.04 Feb 15, 2025
109 checks passed
@jameslamb jameslamb deleted the conda-env branch February 18, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@vyasr vyasr Awaiting requested review from vyasr

@mroeschke mroeschke Awaiting requested review from mroeschke

@davidwendt davidwendt Awaiting requested review from davidwendt

Assignees

@jameslamb jameslamb

@Matt711 Matt711

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameslamb @davidwendt @Matt711 @KyleFromNVIDIA
0