8000 Fix keychain biometric prompts on Android by janicduplessis · Pull Request #6631 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix keychain biometric prompts on Android #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Fix keychain biometric prompts on Android #6631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87e97b7
Use storage type RSA
janicduplessis May 16, 2025
141a994
Log supported biometry result
janicduplessis May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/keychain/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
SharedWebCredentials,
SetOptions,
GetOptions,
STORAGE_TYPE,
} from 'react-native-keychain';
import { MMKV } from 'react-native-mmkv';

Expand Down Expand Up @@ -323,8 +324,9 @@ export async function clear() {
* Wrapper around the underlying library's method by the same name.
*/
export async function getSupportedBiometryType(): Promise<BIOMETRY_TYPE | undefined> {
logger.debug(`[keychain]: getSupportedBiometryType`, {}, logger.DebugContext.keychain);
return (await originalGetSupportedBiometryType()) || undefined;
const result = (await originalGetSupportedBiometryType()) || undefined;
logger.debug(`[keychain]: getSupportedBiometryType result: ${result}`, {}, logger.DebugContext.keychain);
return result;
}

/**
Expand Down Expand Up @@ -379,5 +381,6 @@ export async function getPrivateAccessControlOptions(): Promise<SetOptions> {
return {
accessControl: ios ? ACCESS_CONTROL.USER_PRESENCE : ACCESS_CONTROL.BIOMETRY_CURRENT_SET_OR_DEVICE_PASSCODE,
accessible: ACCESSIBLE.WHEN_UNLOCKED_THIS_DEVICE_ONLY,
storage: STORAGE_TYPE.RSA,
};
}
Loading
0