Fix keychain biometric prompts on Android #6631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
janicduplessis
force-pushed
the
@janic/fix-keychain
branch
from
May 16, 2025 14:24
c13f0a5 to
87e97b7
Compare
|
Updated with our latest solution |
ibrahimtaveras00
pushed a commit
that referenced
this pull request
May 19, 2025
* Use storage type RSA * Log supported biometry result
BrodyHughes
pushed a commit
that referenced
this pull request
May 21, 2025
* Use storage type RSA * Log supported biometry result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2622
What changed (plus any additional context for devs)
When upgrading
react-native-keychainto v9 it now uses insteadBLOCK_MODE_GCMofBLOCK_MODE_ECBwhich supports biometrics authentication. This means that it will prompt for biometrics when trying to encrypt or decrypt values.The issue is that when restoring multiple wallets from a backup it executes many operations requiring encryption in a row and it seems like pixel device rate limit how often the prompt can be shown and the encryption key generated is only valid for 5 seconds because of the config in react-native-keychain. This means that sometimes the generated key is expired, but the system will not allow showing a biometrics prompt yet.
To fix this we can increase the validity of the key to 5 minutes to reduce the number of prompts, and I think this still keeps good safety, while avoiding to spam the user.
Another alternative would be to force using an encryption method without biometrics prompt, but this is better in my opinion.
Screen recordings / screenshots
Tested by @ibrahimtaveras00 on Pixel device where the issue happened.
screen-20250514-181209.mp4
What to test
Restore a wallet from backup as described in the notion document.