Update documentation and structure in Speech::ModelCombination #133
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eugen Beck <curufinwe@users.noreply.github.com>
curufinwe
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not too important, just some minor restructuring in the class ModelCombination.
Actually I just wanted to improve the documentation, as it did not make sense to me. However, I also saw that the order of the function implementations was a bit messy and needed a small reordering and reformatting, this somehow bothered me.
In #106 the function
build()was added to the header, but it's not implemented or used, so I hope it's okay that I just removed it?Mode useLexiconisn't used either, but I guess this is kept for compatibility reasons? Should we maybe think about deleting that as well?Feel free to do any changes yourself!