Use dtonlnay instead of actions-rs #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4453a44 to
496a8a8
Compare
639640b to
e6be879
Compare
e6be879 to
22ad1a5
Compare
|
Will investigate |
495b148 to
9242c3d
Compare
Currently we use the `actions-rs` GitHub action to run our tests. It seems the project is now unmaintained [0]. Well known Rust developer dtonlnay maintains a GitHub action that can be used instead. Replace all uses of `actions-rs/toolchain` with `dtonlnay/rust-toolchain`. Note that with the new action there is no way to configure the toolchain, instead a different `uses` statement is required - this means we have to split our jobs up by toolchain. This is arguably cleaner anyways. Note that with this patch applied the "no-std" tests are now _not_ run for MSRV since we explicitly support "no-std" only for the 1.47 and above toolchains - strange that this was working? [0] actions-rs/toolchain#216
9242c3d to
4201612
Compare
sanket1729
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
ACK 4201612. Verified that we did not miss any checks in the translation.
elichai
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done on top of #1508
Currently we use the
actions-rsGitHub action to run our tests. It seems the project is now unmaintained [0].Well known Rust developer dtonlnay maintains a GitHub action that can be used instead.
Replace all uses of
actions-rs/toolchainwithdtonlnay/rust-toolchain. Note that with the new action there is no way to configure the toolchain, instead a differentusesstatement is required - this means we have to split our jobs up by toolchain. This is arguably cleaner anyways.Note that with this patch applied the "no-std" tests are now not run for MSRV since we explicitly support "no-std" only for the 1.47 and above toolchains - strange that this was working?
[0] actions-rs/toolchain#216