-
Notifications
You must be signed in to change notification settings - Fork 831
Use cargo install cross --locked
#1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cargo install cross --locked
#1508
Conversation
`cross` currently fails to install, this has been reported already cross-rs/cross#1177 The workaround is to use `cargo install --locked`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0aef157
Maybe this isn't even a workaround but the proper way of doing things.
Cross tests are running again so we do not need this now but it doesn't hurt. I'm not sure exactly how caching works in the CI VMs so I don't know exactly where the lock file is coming from. @Kixunil why did you say this is the proper way? EDIT: I did a bit of reading about github actions and caching and we don't do any caching so I don't actually see why the |
Because it will avoid problems like this in the future. (Assuming published crates were tested with the lock files they published.)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0aef157
4201612 Use dtonlnay instead of actions-rs (Tobin C. Harding) Pull request description: Done on top of #1508 Currently we use the `actions-rs` GitHub action to run our tests. It seems the project is now unmaintained [0]. Well known Rust developer dtonlnay maintains a GitHub action that can be used instead. Replace all uses of `actions-rs/toolchain` with `dtonlnay/rust-toolchain`. Note that with the new action there is no way to configure the toolchain, instead a different `uses` statement is required - this means we have to split our jobs up by toolchain. This is arguably cleaner anyways. Note that with this patch applied the "no-std" tests are now _not_ run for MSRV since we explicitly support "no-std" only for the 1.47 and above toolchains - strange that this was working? [0] actions-rs/toolchain#216 ACKs for top commit: sanket1729: ACK 4201612. Verified that we did not miss any checks in the translation. elichai: ACK 4201612 Tree-SHA512: 117b35953c7e0d93ff1ea76fbff948d9a50aff9b3d0854beced540321f84eb83510af23067ff2ebc29b8d9c59b3ca205beeecde6e968bc619e21430b951f02cb
Oh, cool - thanks man. |
cross
currently fails to install, this has been reported alreadycross-rs/cross#1177
The workaround is to use
cargo install --locked
.