New controller example + ClientNode features #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request introduces a new controller example and several new features for ClientNode, including decommissioning. It also includes a significant amount of refactoring across the codebase, especially in the mock networking and behavior components, which improves the overall structure and robustness.
I've found a few issues that need attention:
- A critical issue in the new
OnOffController.tsexample where command-line argument parsing is incorrect. - A high-severity issue in
Promises.tsthat could causewithTimeoutto hang. - A high-severity typing regression in
ClusterInterface.tsthat removes the distinction between optional and mandatory commands.
Once these are addressed, this will be a great addition to the project.
c4a946d to
6c1b350
Compare
* Adds an example that commissions/decommissions/toggles a device that supports On/Off * Implement input fields for client invocation via Interactable * Implement decommissioning for ClientNode
Plus one more cycle in @matter/node that the cycle logic didn't seem to detect.
Apollon77
approved these changes
Jul 2, 2025
|
All comments during review and infos, so can be ignored and discussed aside or put to todo list for the new API ... were basically just thoughts |
And updates to control-onoff
- Remove "decommission" - "delete" decommission properly removes node from fabric - "erase" force removal without properly decommissioning
Apollon77
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New controller example + ClientNode features
Adds an example that commissions/decommissions/toggles a device that supports On/Off
Implement input fields for client invocation via Interactable
Implement decommissioning for ClientNode
Needs to merge after #2200