Client node round 4 #2200
Merged
Client node round 4 #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request includes several updates and refactorings, including new error classes, improvements to network simulation, and refactoring of the storage layer. The changes look good overall, but there are a few areas that could be improved, such as error handling and code comments. The style guide was followed.
Apollon77
approved these changes
Jun 28, 2025
packages/node/src/behavior/system/commissioning/CommissioningClient.ts
Outdated
Show resolved
Hide resolved
Apollon77
reviewed
Jun 28, 2025
|
And please add some Changelog entries :-) |
Apollon77
reviewed
Jun 29, 2025
This is a large round of changes that fleshes out the Node API for client usage. Finishes off the controller features for ServerNode and fleshes out ClientNode to the point where it is largely functional. Tests cover commissioning, syncing of attributes and endpoint structure, invoking a commands and reloading from cached attributes. Other areas of improvement include: * Upgrades to network simulation * A new equivalent to the old "IntegrationTest" that performs in-process test of a matter.js controller against a matter.js device * Refactoring of the storage layer for `@matter/node` which has always been a bit convoluted * Misc. test harness fixes and upgrades * A new protocol-level client implementation in ClientInteractable and ClientSubscriptions * Improved support for IDs or names for keys in persisted Datasource values * Datasource features to support underlying mutated externally rather than via ValueSupervisor * Adds `commands` and `commandsFor` to allow for invocation directly from `Endpoint` API without creating a behavior * Standard implementations of individual error classes for each `Status` code, and logic to automatically throw correct subclass based on a status code * Proper support for suppressed errors generated by `using` * Elimination of cyclical imports in @matter/node * Tweaks to behavior generation to reduce the number of redundant types injected into declaration files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large round of changes that fleshes out the Node API for client usage.
Finishes off the controller features for ServerNode and fleshes out ClientNode to the point where it is largely functional. Tests cover commissioning, syncing of attributes and endpoint structure, invoking a commands and reloading from cached attributes.
Other areas of improvement include:
Upgrades to network simulation
A new equivalent to the old "IntegrationTest" that performs in-process test of a matter.js controller against a matter.js device
Refactoring of the storage layer for
@matter/nodewhich has always been a bit convolutedMisc. test harness fixes and upgrades
A new protocol-level client implementation in ClientInteractable and ClientSubscriptions
Improved support for IDs or names for keys in persisted Datasource values
Datasource features to support underlying mutated externally rather than via ValueSupervisor
Adds
commandsandcommandsForto allow for invocation directly fromEndpointAPI without creating a behaviorStandard implementations of individual error classes for each
Statuscode, and logic to automatically throw correct subclass based on a status codeProper support for suppressed errors generated by
usingElimination of cyclical imports in @matter/node
Tweaks to behavior generation to reduce the number of redundant types injected into declaration files