8000 Modules gradient issue · Issue #759 · polybar/polybar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modules gradient issue #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flameshikari opened this issue Sep 16, 2017 · 10 comments
Closed

Modules gradient issue #759

flameshikari opened this issue Sep 16, 2017 · 10 comments
Assignees
@patrick96
Labels
bug
Milestone
3.2.0

Comments

@flameshikari
Copy link
flameshikari commented Sep 16, 2017 •
edited
Loading

My bar have gradient with two colors. When I used version 3.0.5 bar looked like this:
Old

But after aur-git update to version 3.0.5-44-ga682d2a I got this:
New

Modules has no gradients now. I read the wiki, but there is nothing about it and I tried some combinations with format-background etc. Any help, please? Should I use one color for the bar?

P. S. Sorry about my English, it isn't my primary language.
@patrick96
Copy link
Member

There is some color weirdness in the latest commits, the issue is tracked in #639.
To confirm that this is actually the issue, could you post the output, when you run polybar with the -s option (for both versions)

@flameshikari
Copy link
Author

Version 3.0.5:
%{l}%{A5:i3wm-wsprev: A4:i3wm-wsnext: A1:i3wm-wsfocus-1:}  %{A A A} %{A1:thunar / &:A3:terminator --working-directory / &: F#38A1E3} %{F#252229}140%{F- A A F-} %{A1:thunar ~ &:A3:t 8000 erminator --working-directory ~ &: F#38A1E3} %{F#252229}343%{F- A A F-} %{F#38A1E3} %{F- A1:terminator -x htop &:}42%{A} %{F#38A1E3} %{F- A1:terminator -x htop &:}19%{A} %{F#38A1E3} %{F- A1:~/.config/polybar/output.sh --battery:}100%{A}%{c}%{A1:~/.config/polybar/output.sh --date:}03:07:16%{A}%{r}%{A1:volmute: A4:volup: A5:voldown: F#38A1E3} %{F-}61%{A A A} %{F#38A1E3}%{F-} %{A1:~/.config/polybar/output.sh --interfaces &:A3:terminator -x nmtui &:}192.168.0.47%{A A} %{A1:xkblayout-state set +1 &: F#38A1E3} %{F#252229} 0%{A F-} %{A1:~/.config/polybar/output.sh --dropbox-notification &:A3:thunar ~/Downloads/Dropbox &: F#38A1E3} %{F#252229}R%{A A F-} %{F#38A1E3} %{F#252229}1%{F-} %{A1:xkblayout-state set +1 &: F#252229}EN%{F#D81A1C A F-}

Version 3.0.5-44-ga682d2a:
%{l}%{A5:i3wm-wsprev: A4:i3wm-wsnext: A1:i3wm-wsfocus-1:}  %{A A A} %{A1:thunar / &:A3:terminator --working-directory / &: F#38A1E3} %{F#252229}140%{F- A A F-} %{A1:thunar ~ &:A3:terminator --working-directory ~ &: F#38A1E3} %{F#252229}343%{F- A A F-} %{F#38A1E3} %{F- A1:terminator -x htop &:}41%{A} %{F#38A1E3} %{F- A1:terminator -x htop &:}22%{A} %{F#38A1E3} %{F- A1:~/.config/polybar/output.sh --battery:}100%{A}%{c}%{A1:~/.config/polybar/output.sh --date:}03:05:38%{A}%{r}%{A1:volmute: A4:volup: A5:voldown: F#38A1E3} %{F-}61%{A A A} %{F#38A1E3}%{F-} %{A1:~/.config/polybar/output.sh --interfaces &:A3:terminator -x nmtui &:}192.168.0.47%{A A} %{A1:xkblayout-state set +1 &: F#38A1E3} %{F#252229} 0%{A F-} %{A1:~/.config/polybar/output.sh --dropbox-notification &:A3:thunar ~/Downloads/Dropbox &: F#38A1E3} %{F#252229}R%{A A F-} %{F#38A1E3} %{F#252229}1%{F-} %{A1:xkblayout-state set +1 &: F#252229}EN%{F#D81A1C A F-}

See no difference.

@patrick96
Copy link
Member

Yeah I don't see any either.
I think I have tracked down the issue. Can you locally revert commit 0bd8f1f and recompile and test if that fixes it.

@flameshikari
Copy link
Author
flameshikari commented Sep 17, 2017 •
edited
Loading

Sorry for delay. I just read some manuals about git, because I'm not so friendly with it. I reverted commit as you said, recompiled it and it works fine now:

Nice

What's now?

@patrick96 patrick96 added the bug label Sep 17, 2017
@patrick96 patrick96 self-assigned this Sep 17, 2017
@patrick96
Copy link
Member

Now, we have figured out what the problem is. That commit you reverted sets the background color when rendering a module to the bar background and doesn't consider a gradient here.

I will try to fix this as soon as we merge #729 as it also messes with the colors.

@flameshikari
Copy link
Author

OK! Thanks for help by the way!

@patrick96 patrick96 added this to the 3.0.6 milestone Sep 17, 2017
@NBonaparte
Copy link
Member

@patrick96 Any updates on a fix? Just wanted to know if you've started working on it, because as it stands, this is the only issue left on the 3.1.0 milestone.

@patrick96
Copy link
Member

Sorry, I forgot about this. I think we can release version 3.1.0 without this fix and just schedule it for 3.2.0, it isn't really a critical bug

@patrick96 patrick96 modified the milestones: 3.1.0, 3.2.0 Nov 3, 2017
@TonCherAmi
Copy link
Contributor

@patrick96 hey, I seem to have managed to fix this, do you mind if I submit a PR?

@patrick96
Copy link
Member

@TonCherAmi Yes! Please do.

TonCherAmi added a commit to TonCherAmi/polybar that referenced this issue Nov 5, 2017
@TonCherAmi
fix(renderer): Only draw text bg if color differs from bar bg polybar…
b34e05f 
…#759
@TonCherAmi TonCherAmi mentioned this issue Nov 5, 2017
Merged
TonCherAmi added a commit to TonCherAmi/polybar that referenced this issue Nov 9, 2017
@TonCherAmi
fix(renderer): Only draw text bg if color differs from bar bg polybar…
fe36e7f 
…#759
patrick96 pushed a commit that referenced this issue Nov 12, 2017
@TonCherAmi @patrick96
fix(renderer): Only draw text bg if color differs from bar bg (#831)
5d2deb1 
Fixes #759 by only drawing text background when its color is different from the background color of the bar itself.

Explicitly setting a module's background to `background-0` now stops working.
patrick96 added a commit that referenced this issue Dec 3, 2017
@patrick96
Release 3.1.0 (#863)
bf16a4d 
Breaking Changes:

* Date module no longer supports non-padded specifiers (i.e. `%-d`) and potentially other specifiers, see #792
  - Check http://en.cppreference.com/w/cpp/io/manip/put_time to see supported specifiers
* Setting background color to `background-0` with gradients (refer to https://github.com/jaagr/polybar/wiki/Known-Issues)

Changelog:

Features:
* Feat(mpd): State-specific formats (`format-playing`, `format-paused`, `format-stopped`) (#567), see #524 
* Feat(ipc): Visibility commands (show, hide, toggle, restart, quit) (b6c5563)
* Feat(shell): Bash completion (#588)
* Feat(menu): `expand-right` option (#658), see #655
* Feat(temperature): hwmon sysfs support (#688), see #404 
* Feat(cursor): Change cursors over clickable/scrollable areas (#727), see #721  
* Feat(temperature): Fahrenheit and Celsius tokens (#804)
* Feat(mpd): Use mpd name tag or URI as fallback for title-less tracks (#823), see #815 

Fixes:
* Fix(i3): Clicking workspaces without index (#521), see #520 
* Fix(parser): Prefix options overriding format options (#729), see #544
* Fix(parser): Overline tags (eebf105)
* Fix(process_util): Prefix shell environment variable (`$POLYBAR_SHELL`) (86ff947), see #566 
* Fix(parser): `%{R}` tag (reverse colors) (0bd8f1f), see #585 
* Fix(renderer): Center block position with tray (389bae2 & #673), see #551 & #672 
* Fix(xworkpaces): Active workspace with XMonad (#587), see #411 & #535 
* Fix(config): Expand tilde, environment variable (d3b0670 & #724), see #603 & #719 
* Fix(build): Remove curlbuild.h (#648), see #647 
* Fix(renderer): Off by one error for actions (#663), see #661 
* Fix(gcc): GCC 7.1 ([jaagr/xpp/#6](polybar/xpp#6))
* Fix(fs): Use `bytes_available` for `percentage_used` (138f5fa), see #710
* Fix(fs): Use `f_frsize` for calculations (a682d2a)
* Fix(date): Remove date string length limitation (#745), see #754 
* Fix(renderer): Nested actions (#772), see #760 and #758
* Fix(i3): Check and warn if current workspace not found (#826), see #824 
* Fix(github): Prevent module disappearing with no connection (#811), see #810 
* Fix(renderer): Module gradients (#831), see #759 
* Fix(build): Update deprecated jsoncpp Reader
NBonaparte pushed a commit to NBonaparte/lemonbuddy that referenced this issue Dec 16, 2017
@TonCherAmi @NBonaparte
fix(renderer): Only draw text bg if color differs from bar bg (polyba…
01386d4 
…r#831)

Fixes polybar#759 by only drawing text background when its color is different from the background color of the bar itself.

Explicitly setting a module's background to `background-0` now stops working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick96 patrick96

Labels
bug
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@patrick96 @NBonaparte @TonCherAmi @flameshikari
0