8000 border-left causes center module to shift · Issue #672 · polybar/polybar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

border-left causes center module to shift #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 22, 2017 · 4 comments
Closed

border-left causes center module to shift #672

ghost opened this issue Jul 22, 2017 · 4 comments
Labels
bug confirmed

Comments

@ghost
Copy link
ghost commented Jul 22, 2017 •
edited by ghost
Loading

Creating a bar with a left border of n pixels causes the center module to shift left the by the same amount (with fixed-center = true). This only seems to occur on the left border, which can be triggered by both border-left-size and border-size.

Configuration used
Screenshot

As shown above, the modules i3 and date are both shifted to the left, replacing them with single character modules (e.g brightness) also has the same effect
@patrick96
Copy link
Member

This behaviour does not appear in the latest release but only if you built against the HEAD of this repo. So downgrading to the latest release v3.0.5 will fix this. I'm tracking down the offending commit now

@patrick96
Copy link
Member

The issue has been introduced in 389bae2, which was a fix for #551. The logic applied there does not seem to work when there is any border on the left side. I'm working on a fix.

patrick96 added a commit to patrick96/polybar that referenced this issue Jul 23, 2017
@patrick96
fix(renderer): Correct center module position
9f4430c 
The changes introduced in 389bae2 to
address polybar#551 did not consider the left border

Now center modules are centered regardless of border (left or right)
settings or tray position

Fixes polybar#672
@patrick96 patrick96 mentioned this issue Jul 23, 2017
Merged
@patrick96
Copy link
Member

I have submitted a pull-request in #673 to address this issue, can you try it out and tell me if it works

@ghost
Copy link
Author
ghost commented Jul 24, 2017 •
edited by ghost
Loading

Yep, its working correctly now. Thanks!

@patrick96 patrick96 mentioned this issue Aug 5, 2017
Closed
NBonaparte pushed a commit that referenced this issue Sep 5, 2017
@patrick96 @NBonaparte
fix(renderer): Correct center module position (#673)
a255a02 
The changes introduced in 389bae2 to
address #551 did not consider the left border

Now center modules are centered regardless of border (left or right)
settings or tray position

Fixes #672
patrick96 added a commit that referenced this issue Dec 3, 2017
@patrick96
Release 3.1.0 (#863)
bf16a4d 
Breaking Changes:

* Date module no longer supports non-padded specifiers (i.e. `%-d`) and potentially other specifiers, see #792
  - Check http://en.cppreference.com/w/cpp/io/manip/put_time to see supported specifiers
* Setting background color to `background-0` with gradients (refer to https://github.com/jaagr/polybar/wiki/Known-Issues)

Changelog:

Features:
* Feat(mpd): State-specific formats (`format-playing`, `format-paused`, `format-stopped`) (#567), see #524 
* Feat(ipc): Visibility commands (show, hide, toggle, restart, quit) (b6c5563)
* Feat(shell): Bash completion (#588)
* Feat(menu): `expand-right` option (#658), see #655
* Feat(temperature): hwmon sysfs support (#688), see #404 
* Feat(cursor): Change cursors over clickable/scrollable areas (#727), see #721  
* Feat(temperature): Fahrenheit and Celsius tokens (#804)
* Feat(mpd): Use mpd name tag or URI as fallback for title-less tracks (#823), see #815 

Fixes:
* Fix(i3): Clicking workspaces without index (#521), see #520 
* Fix(parser): Prefix options overriding format options (#729), see #544
* Fix(parser): Overline tags (eebf105)
* Fix(process_util): Prefix shell environment variable (`$POLYBAR_SHELL`) (86ff947), see #566 
* Fix(parser): `%{R}` tag (reverse colors) (0bd8f1f), see #585 
* Fix(renderer): Center block position with tray (389bae2 & #673), see #551 & #672 
* Fix(xworkpaces): Active workspace with XMonad (#587), see #411 & #535 
* Fix(config): Expand tilde, environment variable (d3b0670 & #724), see #603 & #719 
* Fix(build): Remove curlbuild.h (#648), see #647 
* Fix(renderer): Off by one error for actions (#663), see #661 
* Fix(gcc): GCC 7.1 ([jaagr/xpp/#6](polybar/xpp#6))
* Fix(fs): Use `bytes_available` for `percentage_used` (138f5fa), see #710
* Fix(fs): Use `f_frsize` for calculations (a682d2a)
* Fix(date): Remove date string length limitation (#745), see #754 
* Fix(renderer): Nested actions (#772), see #760 and #758
* Fix(i3): Check and warn if current workspace not found (#826), see #824 
* Fix(github): Prevent module disappearing with no connection (#811), see #810 
* Fix(renderer): Module gradients (#831), see #759 
* Fix(build): Update deprecated jsoncpp Reader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrick96
0