8000 Rebase to upstream whereabouts by xagent003 · Pull Request #10 · platform9/whereabouts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rebase to upstream whereabouts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 466 commits into
base: master
Choose a base branch
from
Open

Rebase to upstream whereabouts #10

wants to merge 466 commits into from

Conversation

xagent003
Copy link

No description provided.

andreaskaris and others added 29 commits April 25, 2023 11:47
@andreaskaris
Refactor IterateForAssignment and GetIPRange
f875495 
Refactor both IterateForAssignment and GetIPRange.
Make sure that IterateForAssignment adheres to a consistent set of
rules for both IPv4 and IPv6:
* Valid IPs are contained within the ipnet, excluding the network and
  broadcast address
* If rangeStart is specified, it is respected if it lies within the
  ipnet
* If rangeEnd is specified, it is respected if it lies within the
  ipnet and if it is >= rangeStart
*  reserveList holds a list of reserved IPs.
*  excludeRanges holds a list of subnets to be excluded (meaning the
   full subnet, including the network and broadcast IP)

Add more unit tests to make sure the above conditions are met.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@BlaineEXE
sign into registry for pushing arm master build
8a201e5 
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@tariq1890
minor fix: update comment in whereabouts cni kubeconfig
ccda994
@jonkerj
fix: improve error handling
b8407ea 
The control loop currently segfaults when none of the config files was
found. This commit makes it error, providing the user with useful
feedback.

Also, L260 returned a `nil` disguised as a var named `err`, which could
be done more explicit.

Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
@jonkerj
fix: refactor tests to have a config file
55b24e2 
It is required per my previous commit, which seemed to break a couple of
tests.

Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
@maiqueb
Merge pull request #323 from equinix-ms/error-for-no-config
8d5d9d1 
Provide error when no config was found
@maiqueb
Merge pull request #318 from BlaineEXE/log-into-registry-for-arm-mast…
e7a15a8 
…er-push

sign into registry for pushing arm master build
@BlaineEXE
fix 'latest-arm' image to build for arm64, not amd64
39e228c 
The build-push action for master 'latest-arm64' images were being done
for amd64 incorrectly. Fix this.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@dougbtv
Merge pull request #328 from BlaineEXE/fix-arm-master-build-was-amd
515fbb9 
fix 'latest-arm' image to build for arm64, not amd64
@sebrandon1
Add dependabot config
d35c157
@dougbtv
Merge pull request #331 from sebrandon1/add_dependabot
ec9aaff 
Add dependabot config
@dougbtv
Merge pull request #322 from andreaskaris/improve-iterate-for-assignm…
475be37 
…ent-separate-commits2

Improve iterate for assignment
@BlaineEXE
build & use multi-arch manifests for doc/crds
03a7bb4 
Build multi-arch manifests (amd64 and arm64) for PR 'build`, 'master'
images, and 'release' images. In the doc/crds/daemonset-install.yaml
file, remove amd64-specific items, and use the 'latest' manifest that
will autoselect the appropriate architecture for the system.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@maiqueb
Merge pull request #329 from BlaineEXE/make-master-and-release-multi-…
fbd57ab 
…arch-manifests

build & use multi-arch manifests for doc/crds
@BlaineEXE
update github action docker buildx action to v2
2ba5b69 
This solves random build/push issues.
See: docker/build-push-action#761 (comment)

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@maiqueb
Merge pull request #345 from BlaineEXE/update-buildx-version
87b0e84 
update github action docker buildx action to v2
@dougbtv
Merge pull request #327 from tariq1890/update-kubecfg
d15b4d5 
minor fix: update comment in whereabouts cni kubeconfig
@andreaskaris
Add network_name to README.md
d433b0f 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
Add overlapping ranges check to network_name feature
f4a278e 
The network_name feature lacked integration for parameter
enable_overlapping_ranges which had to be set to off. Add support for
this parameter to networks with a non-default network_name by creating
overlappingipreservations which are prefixed with the network_name.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
Add E2E tests for OverlappingRangeIPReservation
adc9c72 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@dougbtv
Merge pull request #355 from andreaskaris/network-name-overlappingipr…
9b72da8 
…eservations

 Add overlapping ranges check to network_name feature
@nicklesimba
Denormalize IP name before checking if pod is alive
f274a0c 
This commit solves the issue of normalized IP names being used for
checking if a pod is alive, which resulted in overlappingrangeipreservations being falsely
deleted by the ip-reconciler.

Signed-off-by: nicklesimba <simha.nikhil@gmail.com>
@andreaskaris
IterateForAssignment: Properly handle invalid syntax for exclude range
e29384d 
Correctly handle errors from parsing exclude ranges to avoid issues with
nil pointer exceptions.
Parse single IP addresses such as 192.168.123.10 or fe02::10 and
convert them to CIDRs by appending the correct prefix.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
Improve AssignmentError message
c7c49b8 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@dougbtv
Merge pull request #366 from andreaskaris/assignment-error
a31fc99 
Improve AssignmentError message
@dougbtv
Merge pull request #365 from andreaskaris/nil-pointer-exclude-range
23e6020 
IterateForAssignment: Properly handle invalid syntax for exclude range
@nicklesimba
added comments and a unit test
fafc631 
Signed-off-by: nicklesimba <simha.nikhil@gmail.com>
@nicklesimba
delete pod after unit test run
b48320a 
Signed-off-by: nicklesimba <simha.nikhil@gmail.com>
@dougbtv
Merge pull request #360 from nicklesimba/ipv6-denormalize-fix
d9cfa5b 
Denormalize IP name before checking if pod is alive
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented Apr 10, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

dependabot bot and others added 2 commits April 15, 2025 03:12
@dependabot
Bump morphy2k/revive-action from 2.7.5 to 2.7.6
0ed4f20 
Bumps [morphy2k/revive-action](https://github.com/morphy2k/revive-action) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/morphy2k/revive-action/releases)
- [Commits](morphy2k/revive-action@v2.7.5...v2.7.6)

---
updated-dependencies:
- dependency-name: morphy2k/revive-action
  dependency-version: 2.7.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@thomasferrandiz
Merge pull request #602 from k8snetworkplumbingwg/dependabot/github_a…
bbb3437 
…ctions/morphy2k/revive-action-2.7.6

Bump morphy2k/revive-action from 2.7.5 to 2.7.6
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented Apr 16, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

thomasferrandiz and others added 4 commits April 23, 2025 14:00
@thomasferrandiz
Align chart with daemonset manifest
f86d279
@thomasferrandiz
Fix source command in scripts
3977939 
In busybox-based images, source does not look in the current directory so an absolute path is needed.
@mlguerrero12
Delete Openshift dockerfile
0151aef 
Upstream should not have Openshift specific files

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
@mlguerrero12
Merge pull request #592 from cyanidium/patch-1
3583797 
Remove duplicate app label from helm chart
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented Apr 23, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

mlguerrero12 and others added 10 commits April 24, 2025 09:52
@mlguerrero12
Merge pull request #606 from mlguerrero12/deleteocpreferences
2fbebb2 
Delete Openshift dockerfile
@mlguerrero12
Add e2e test for pod cleanup controller
7258363 
This verifies that the pod controller is working

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
@thomasferrandiz
Bump go to 1.24 in go.mod
4b08da7
@bpickard22
Merge pull request #608 from mlguerrero12/addpodcontrollere2etest
42b1df7 
Add e2e test for pod cleanup controller
@thomasferrandiz
Add reminder to update chart files along with manifest files
a636b2e
@mlguerrero12
Merge pull request #605 from thomasferrandiz/fix-chart-and-source
bccf0ba 
Fix chart and source command in scripts
@mlguerrero12
Merge pull request #604 from thomasferrandiz/bump-go-1.24
bfd25c6 
Bump go to 1.24 in go.mod
@dependabot
Bump golang.org/x/net from 0.36.0 to 0.38.0
59414a6 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@bpickard22
Merge pull request #603 from k8snetworkplumbingwg/dependabot/go_modul…
b4a05c9 
…es/golang.org/x/net-0.38.0

Bump golang.org/x/net from 0.36.0 to 0.38.0
@bpickard22
Merge pull request #544 from rrajendran17/readme-changes
9bdc601 
correct ip address range example
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented Apr 25, 2025 •
A373
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

1 similar comment
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented Apr 25, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

dependabot bot and others added 3 commits April 25, 2025 03:45
@dependabot
Bump the other-go-modules group with 8 updates
1a37f45 
Bumps the other-go-modules group with 8 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/containernetworking/cni](https://github.com/containernetworking/cni) | `1.2.3` | `1.3.0` |
| [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) | `1.6.1` | `1.6.2` |
| [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) | `1.7.0` | `1.7.6` |
| [github.com/onsi/gomega](https://github.com/onsi/gomega) | `1.36.2` | `1.37.0` |
| [gomodules.xyz/jsonpatch/v2](https://github.com/gomodules/jsonpatch) | `2.4.0` | `2.5.0` |
| [github.com/go-co-op/gocron/v2](https://github.com/go-co-op/gocron) | `2.12.4` | `2.16.1` |
| [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) | `1.8.0` | `1.9.0` |
| [golang.org/x/time](https://github.com/golang/time) | `0.8.0` | `0.11.0` |


Updates `github.com/containernetworking/cni` from 1.2.3 to 1.3.0
- [Release notes](https://github.com/containernetworking/cni/releases)
- [Commits](containernetworking/cni@v1.2.3...v1.3.0)

Updates `github.com/containernetworking/plugins` from 1.6.1 to 1.6.2
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](containernetworking/plugins@v1.6.1...v1.6.2)

Updates `github.com/k8snetworkplumbingwg/network-attachment-definition-client` from 1.7.0 to 1.7.6
- [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases)
- [Commits](k8snetworkplumbingwg/network-attachment-definition-client@v1.7.0...v1.7.6)

Updates `github.com/onsi/gomega` from 1.36.2 to 1.37.0
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.36.2...v1.37.0)

Updates `gomodules.xyz/jsonpatch/v2` from 2.4.0 to 2.5.0
- [Release notes](https://github.com/gomodules/jsonpatch/releases)
- [Changelog](https://github.com/gomodules/jsonpatch/blob/release-2.0/CHANGELOG.md)
- [Commits](gomodules/jsonpatch@v2.4.0...v2.5.0)

Updates `github.com/go-co-op/gocron/v2` from 2.12.4 to 2.16.1
- [Release notes](https://github.com/go-co-op/gocron/releases)
- [Commits](go-co-op/gocron@v2.12.4...v2.16.1)

Updates `github.com/fsnotify/fsnotify` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.8.0...v1.9.0)

Updates `golang.org/x/time` from 0.8.0 to 0.11.0
- [Commits](golang/time@v0.8.0...v0.11.0)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/cni
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: github.com/containernetworking/plugins
  dependency-version: 1.6.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other-go-modules
- dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client
  dependency-version: 1.7.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other-go-modules
- dependency-name: github.com/onsi/gomega
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: gomodules.xyz/jsonpatch/v2
  dependency-version: 2.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: github.com/go-co-op/gocron/v2
  dependency-version: 2.16.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: github.com/fsnotify/fsnotify
  dependency-version: 1.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: golang.org/x/time
  dependency-version: 0.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
@mlguerrero12
Refactor recover from an exhausted IP pool test
08b725a 
These changes are meant to make the recover from an
exhausted IP pool test more stable.

Signed-off-by: Marcelo <marguerr@redhat.com>
@mlguerrero12
Merge pull request #609 from k8snetworkplumbingwg/dependabot/go_modul…
0734cb1 
…es/other-go-modules-3fd7b7ad37

Bump the other-go-modules group with 8 updates
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented May 7, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

@dougbtv
Merge pull request #611 from mlguerrero12/fixflakytest
ef08a65 
Refactor recover from an exhausted IP pool test
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented May 8, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

dependabot bot and others added 2 commits May 19, 2025 03:10
@dependabot
Bump the other-go-modules group across 1 directory with 2 updates
5b1d9c0 
Bumps the other-go-modules group with 2 updates in the / directory: [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) and [github.com/go-co-op/gocron/v2](https://github.com/go-co-op/gocron).


Updates `github.com/containernetworking/plugins` from 1.6.2 to 1.7.1
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](containernetworking/plugins@v1.6.2...v1.7.1)

Updates `github.com/go-co-op/gocron/v2` from 2.16.1 to 2.16.2
- [Release notes](https://github.com/go-co-op/gocron/releases)
- [Commits](go-co-op/gocron@v2.16.1...v2.16.2)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/plugins
  dependency-version: 1.7.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other-go-modules
- dependency-name: github.com/go-co-op/gocron/v2
  dependency-version: 2.16.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other-go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
@mlguerrero12
Merge pull request #613 from k8snetworkplumbingwg/dependabot/go_modul…
db4e172 
…es/other-go-modules-b4f8590dc6

Bump the other-go-modules group across 1 directory with 2 updates
@bito-code-review Bito Code Review
Copy link
bito-code-review bot commented May 19, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruizen cruizen Awaiting requested review from cruizen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0