8000 fix 'latest-arm' image to build for arm64, not amd64 by BlaineEXE · Pull Request #328 · k8snetworkplumbingwg/whereabouts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix 'latest-arm' image to build for arm64, not amd64 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

fix 'latest-arm' image to build for arm64, not amd64 #328

merged 1 commit into from
May 9, 2023

Conversation

BlaineEXE
Copy link
Contributor

The build-push action for master 'latest-arm64' images were being done for amd64 incorrectly. Fix this.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

@BlaineEXE
fix 'latest-arm' image to build for arm64, not amd64
39e228c 
The build-push action for master 'latest-arm64' images were being done
for amd64 incorrectly. Fix this.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@BlaineEXE BlaineEXE requested a review from dougbtv as a code owner May 9, 2023 19:04
@coveralls
Copy link
coveralls commented May 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4929517118

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.976%
Totals Coverage Status
Change from base Build 4923421455: 0.0%
Covered Lines: 976
Relevant Lines: 1356
💛 - Coveralls

dougbtv
dougbtv approved these changes May 9, 2023
View reviewed changes
Copy link
Member
@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dougbtv dougbtv merged commit 515fbb9 into k8snetworkplumbingwg:master May 9, 2023
@BlaineEXE BlaineEXE deleted the fix-arm-master-build-was-amd branch May 9, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlaineEXE @coveralls @dougbtv
0