parser: support admin alter ddl jobs grammar (#57268)
#57512
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57512 +/- ##
================================================
Coverage ? 57.2166%
================================================
Files ? 1770
Lines ? 628845
Branches ? 0
================================================
Hits ? 359804
Misses ? 244989
Partials ? 24052
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -538,6 +538,17 @@ func TestAdminStmt(t *testing.T) { | |||
| {"admin set bdr role secondary", true, "ADMIN SET BDR ROLE SECONDARY"}, | |||
| {"admin unset bdr role", true, "ADMIN UNSET BDR ROLE"}, | |||
| {"admin show bdr role", true, "ADMIN SHOW BDR ROLE"}, | |||
| // for alter job | |||
There was a problem hiding this comment.
Please add multi jobs alter test cases.
There was a problem hiding this comment.
Currently, we only support modify one job's config each time, will support multi jobs later if necessary.
| {"admin alter ddl jobs 1 batch_size = 3", true, "ADMIN ALTER DDL JOBS 1 batch_size = 3"}, | ||
| {"admin alter ddl jobs 1 batch_size = ", false, ""}, | ||
| {"admin alter ddl jobs 1 batch_size", false, ""}, | ||
| {"admin alter ddl jobs 1 max_write_speed = 4", true, "ADMIN ALTER DDL JOBS 1 max_write_speed = 4"}, |
There was a problem hiding this comment.
what is the 4 means max_write_speed?
There was a problem hiding this comment.
The default unit is byte, here supports the style of omitting units.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lance6716, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57268
What problem does this PR solve?
Issue Number: ref #57229 #57526
Problem Summary:
What changed and how does it work?
ref #57229, we need a new grammer to dynamically adjust related parameters during the ddl operation, Similar to the existed
admin cancel ...andadmin pause ..., we useadmin alter ...as an syntax entrance to implement the adjust logic.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.