parser: support admin alter ddl jobs grammar
#57268
Conversation
|
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/parser/parser.y
Outdated
| { | ||
| $$ = &ast.AdminStmt{ | ||
| Tp: ast.AdminAlterDDLJob, | ||
| JobNumber: $5.(int64), |
There was a problem hiding this comment.
Only one job_id is permitted
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57268 +/- ##
================================================
+ Coverage 72.9242% 73.8710% +0.9467%
================================================
Files 1659 1668 +9
Lines 458547 465043 +6496
================================================
+ Hits 334392 343532 +9140
+ Misses 103613 101001 -2612
+ Partials 20542 20510 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
admin alter ddl jobs 'job_id' xxx = xxx grammeradmin alter ddl jobs grammar
[LGTM Timeline notifier]Timeline:
|
|
@benmeadowcroft @BornChanger @yudongusa please help take a look |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #57229
Problem Summary:
What changed and how does it work?
ref #57229, we need a new grammer to dynamically adjust related parameters during the ddl operation, Similar to the existed
admin cancel ...andadmin pause ..., we useadmin alter ...as an syntax entrance to implement the adjust logic.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.