Implementation of stride grid search #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 28, 2019 14:41
jkruzik
reviewed
Jan 9, 2020
| } | ||
|
|
||
| if (m == 1) { | ||
| PetscInfo2(svm,"selected best C=%.4f (score=%f)\n",grid[p],score_best); |
There was a problem hiding this comment.
use %g and cast to double
See PETSc dev guide section 2.2.3 19.
There was a problem hiding this comment.
The issue also appears in other parts of code. I think it is better to do it in another PR related to fixing code-style.
There was a problem hiding this comment.
I think we should not introduce a potential bug (not casting will be undefined behaviour when PetscReal is not double/float?) just because it is somewhere else in the code.
I added note in #3 to fix this in other parts of the code.
jkruzik
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature contains a new implementation (say reimplementation) of hyper optimization technique, namely grid search, such that one can specify the start and endpoints of a grid, and newly discretization step. It also supports going through a grid in reverse order.