8000 Fix code style · Issue #3 · permon/permonsvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix code style #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
7 tasks
jkruzik opened this issue Nov 22, 2019 · 1 comment
Open
7 tasks

Fix code style #3

jkruzik opened this issue Nov 22, 2019 · 1 comment
Assignees
@jkruzik
Labels
codestyle

Comments

@jkruzik
Copy link
Member
jkruzik commented Nov 22, 2019 •
edited
Loading

Fix code style according to PETSc style guide and remove/rename legacy macros/functions.

  • Replace TRY() with ierr= ;CHKERRQ(ierr);
  • Do not use a space after the ) in a cast or between the type and the * in a cast.
  • replace %f formatting string with %g and always cast to double
  • fix whitespace issues in function declarations, calls, and variable declarations
  • remove trailing whitespaces
  • remove #undef __FUNCT__ / #define __FUNCT__ (Get rid of #undef __FUNCT__ / #define __FUNCT__ permon#17)
  • remove FLLOP macros/functions in favour of PETSC macros/functions or rename them to PERMON (suggestions for permonsys.h permon#41)

The issues are valid also for PermonQP and should be fixed at the same time.
@mpecha
Copy link
Member
mpecha commented Nov 22, 2019

I think, this fix is not so urgent and can wait after fixing the code style in core package. :)

@jkruzik jkruzik mentioned this issue Jan 13, 2020
Merged
@jkruzik jkruzik mentioned this issue May 7, 2020
Open
@jkruzik jkruzik self-assigned this May 21, 2020
@jkruzik jkruzik mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkruzik jkruzik

Labels
codestyle
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpecha @haplav @jkruzik
0