10000 Get rid of #undef __FUNCT__ / #define __FUNCT__ · Issue #17 · permon/permon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get rid of #undef __FUNCT__ / #define __FUNCT__ #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
haplav opened this issue Apr 28, 2020 · 1 comment
Open

Get rid of #undef __FUNCT__ / #define __FUNCT__ #17

haplav opened this issue Apr 28, 2020 · 1 comment
Assignees
@davidhrbac @jkruzik

Comments

@haplav
Copy link
Collaborator
haplav commented Apr 28, 2020

All these

#undef __FUNCT__
#define __FUNCT__ "main"

are legacy of > 2 years old PETSc and should be removed.

Following up #12 (review)
@haplav haplav self-assigned this Apr 28, 2020
@haplav haplav removed their assignment May 6, 2020
@jkruzik
Copy link
Member
jkruzik commented May 7, 2020

I will do it together with a larger code style fix akin to permon/permonsvm#3 for both permon and permonsvm.

@jkruzik jkruzik self-assigned this May 7, 2020
@jkruzik jkruzik mentioned this issue May 21, 2020
Open
7 tasks
@davidhrbac davidhrbac self-assigned this Nov 23, 2022
davidhrbac added a commit to davidhrbac/permon that referenced this issue Nov 23, 2022
@davidhrbac
Fixes permon#17; Removed obsolete undef
dfadf23
@davidhrbac davidhrbac linked a pull request Nov 23, 2022 that will close this issue
Get rid of undef funct & define funct #73
Closed
davidhrbac added a commit to davidhrbac/permon that referenced this issue Nov 23, 2022
@davidhrbac
Fixes permon#17; Removed obsolete undef
a97c59b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhrbac davidhrbac

@jkruzik jkruzik

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get rid of undef funct & define funct davidhrbac/permon
3 participants
@davidhrbac @haplav @jkruzik
0