8000 Fix unconditional openssl import in DTLS by VincentVanlaer · Pull Request #2779 · python-trio/trio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix unconditional openssl import in DTLS #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix unconditional openssl import in DTLS #2779

merged 1 commit into from
Sep 1, 2023

Conversation

VincentVanlaer
Copy link
Member

No description provided.

@codecov
Copy link
codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #2779 (d93f678) into master (e97bcb6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
- Coverage   98.94%   98.94%   -0.01%     
==========================================
  Files         113      113              
  Lines       16852    16851       -1     
  Branches     3032     3032              
==========================================
- Hits        16674    16673       -1     
  Misses        123      123              
  Partials       55       55
Files Changed Coverage Δ
trio/_dtls.py 96.59% <ø> (-0.01%) ⬇️

TeamSpen210
TeamSpen210 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor
@TeamSpen210 TeamSpen210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if we're already documenting support for this. Though, we should probably add a test to confirm that importing trio is possible without OpenSSL installed. Perhaps by setting sys.modules["OpenSSL"] = None before importing in a subprocess?

@TeamSpen210 TeamSpen210 requested a review from jakkdl August 31, 2023 07:51
@jakkdl
Copy link
Member
jakkdl commented Sep 1, 2023

Ah, thanks for the PR! Looks like another reason for setting up tox environments for testing (#2699), to check that we don't get hard dependencies on anything in test-requirements. And another nail in the coffin for runtime type-checking #2687

@jakkdl jakkdl merged commit d3255a0 into python-trio:master Sep 1, 2023
@jakkdl jakkdl mentioned this pull request Sep 1, 2023
Merged
@VincentVanlaer VincentVanlaer deleted the fix-required-openssl branch September 1, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeamSpen210 TeamSpen210 TeamSpen210 approved these changes

@jakkdl jakkdl Awaiting requested review from jakkdl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentVanlaer @jakkdl @TeamSpen210
0