8000 Use tox and/or pre-commit for static analysis checks · Issue #2699 · python-trio/trio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use tox and/or pre-commit for static analysis checks #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakkdl opened this issue Jul 12, 2023 · 2 comments · Fixed by #3196
Closed

Use tox and/or pre-commit for static analysis checks #2699

jakkdl opened this issue Jul 12, 2023 · 2 comments · Fixed by #3196

Comments

@jakkdl
Copy link
Member
jakkdl commented Jul 12, 2023

check.sh is getting kinda bloated with the addition of isort, codespell, and check_type_completeness - and trying to read the output from it to figure out what actually failed is kind of a pain. I've been using tox and pre-commit locally to avoid having to deal with the shell scripts, and been copying over configuration and commands, and maybe it's about time to share that and maybe make it official instead.

Setting up test environments in tox would also help people testing on different python versions and the like, although I've had some troubles with test_exports/ from inside tox envs (having to mess with PY_IGNORE_IMPORTMISMATCH, custom install_commands, and the like. It's definitely doable though)
@jakkdl jakkdl mentioned this issue Jul 30, 2023
Merged
@jakkdl jakkdl mentioned this issue Aug 8, 2023
Merged
@jakkdl jakkdl mentioned this issue Sep 1, 2023
Merged
@jakkdl jakkdl mentioned this issue Dec 17, 2024
Merged
@jakkdl jakkdl mentioned this issue Jan 31, 2025
Merged
@webknjaz webknjaz linked a pull request Feb 24, 2025 that will close this issue
add initial tox.ini #3196
Merged
@webknjaz
Copy link
Member

Did you mean to close this via #3196?
82F4

@jakkdl
Copy link
Member Author
jakkdl commented Feb 24, 2025

yeah this can be closed 🚀

@jakkdl jakkdl closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add initial tox.ini jakkdl/trio
2 participants
@webknjaz @jakkdl
0