Expose lu_factor_batched_cublas #73877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
✅ No Failures (0 Pending)As of commit cbb7fdf (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 7, 2022
Closed
Closed
Closed
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
|
pytorch/aten/src/ATen/native/cuda/linalg/BatchLinearAlgebraLib.cpp Lines 293 to 295 in bd13bc6 Also the description of the PR that added this function says |
|
For what is worth, that PR just tested up to batches of 4 matrices, which is not very representative either. |
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
This was referenced Mar 10, 2022
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
This was referenced May 17, 2022
Closed
Closed
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
nikitaved
reviewed
May 17, 2022
Comment on lines
+109
to
+112
| auto a_ptr_array_data = reinterpret_cast<scalar_t**>(a_ptr_array.data_ptr()); | ||
|
|
||
| at::cuda::blas::getrfBatched(n, a_ptr_array_data, lda, pivots_data, infos_data, batch_size); | ||
| #endif |
There was a problem hiding this comment.
This one handles non-contiguous inputs, right? Or is it done one level above in the stack?
There was a problem hiding this comment.
non-contiguous inputs are handled in the parent fucntion, that is, in linalg_lu_factor
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
IvanYashchuk
approved these changes
May 18, 2022
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in `linalg.lu_factor`. [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
Summary: We had bindings for this function, but they were not exposed as a function inside ATen. This PR exposes them. This function is tested in the next PR of the stack, where it is used in linalg.lu_solve. Pull Request resolved: #73877 Approved by: https://github.com/nikitaved, https://github.com/IvanYashchuk, https://github.com/mruberry Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1880d293b64badac1b74e9c6bb0152e3950d3f7e Reviewed By: osalpekar Differential Revision: D37089123 Pulled By: osalpekar fbshipit-source-id: 55989cba1b2f8e0cbb1b7dae326bf2e52e3b0fb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We had bindings for this function, but they were not exposed as a
function inside ATen. This PR exposes them.
This function is tested in the next PR of the stack, where it is used in
linalg.lu_factor.