8000 Deprecate torch.lu by lezcano · Pull Request #77636 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecate torch.lu #77636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Deprecate torch.lu #77636

wants to merge 10 commits into from

Conversation

lezcano
Copy link
Collaborator
@lezcano lezcano commented May 17, 2022 •
edited
Loading

Stack from ghstack:

This PR deprecates torch.lu in favor of torch.linalg.lu_factor.
A upgrade guide is added to the documentation for torch.lu.

Note this PR DOES NOT remove torch.lu.

Reland #73804

BC-breaking note

Deprecate torch.lu in favor of linalg.lu_factor

The new operation has a cleaner API and better docs. The update rule is as follows:

Version 1.12.0

LU1, pivots1, info = torch.lu(A, compute_pivots)
LU2, pivots2, info = torch.lu(A, compute_pivots, get_infos=True)

Version 1.13.0

LU1, pivots1 = torch.linalg.lu_factor(A, compute_pivots)
LU2, pivots2, info = torch.linalg.lu_factor_ex(A, compute_pivots)

@lezcano
Deprecate torch.lu
651ddd5 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request May 17, 2022
Closed
@lezcano lezcano mentioned this pull request May 17, 2022
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 17, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit c1cf627 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 17, 2022
Closed
Closed
Closed
Closed
@lezcano lezcano added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul release notes: linalg_frontend release notes category topic: deprecation topic category labels May 17, 2022
@lezcano lezcano requested review from malfet and removed request for nikitaved, ngimel, IvanYashchuk and mruberry May 17, 2022 09:08
@lezcano lezcano mentioned this pull request May 17, 2022
Closed
lezcano added 7 commits May 17, 2022 10:31
@lezcano
Update on "Deprecate torch.lu"
6610d9f 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
e66114e 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
9ae26ff 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
ff12b7d 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
38d8a2c 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
46e7122 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
b689183 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
lezcano added 2 commits May 25, 2022 17:27
@lezcano
Update on "Deprecate torch.lu"
b6913b4 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
@lezcano
Update on "Deprecate torch.lu"
c1cf627 
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
@lezcano @facebook-github-bot
Deprecate torch.lu (#77636)
5ebc0f6 
Summary:
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Pull Request resolved: #77636

Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f7b9a4688091d1118a4052dea6a73875fb956f79

Reviewed By: osalpekar

Differential Revision: D36993319

Pulled By: osalpekar

fbshipit-source-id: 13bbcee3c95820007691ab0fb357a9475c6d9a1e
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/74/head branch June 11, 2022 14:17
@lezcano lezcano mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source release notes: linalg_frontend release notes category topic: deprecation topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lezcano @facebook-github-bot @malfet @pytorchbot
0