8000 Fix code that triggers BytesWarning by aphedges · Pull Request #79868 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix code that triggers BytesWarning #79868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix code that triggers BytesWarning #79868

wants to merge 4 commits into from

Conversation

aphedges
Copy link
Contributor

Fixes #74812.

I have fixed the multiple instances in the repository that trigger
BytesWarning, and I have enabled the -bb option when tests are run
to prevent regressions.

@aphedges aphedges requested a review from a team as a code owner June 20, 2022 14:45
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 20, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit aa0f624 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-docs / build-docs (cpp) (1/1)

Step: "Build cpp docs" (full log | diagnosis details | 🔁 rerun)

2022-06-20T16:53:54.6877131Z ##[error]Process completed with exit code 137. 
2022-06-20T16:49:11.3852607Z �[01mwriting output... �[39;49;00m[ 90%] �[32mapi/structc10_1_1_capsule .. api/structtorch_1_1enumtype_1_1k_l_s_t_m�[39;49;00m
2022-06-20T16:49:21.1109876Z �[01mwriting output... �[39;49;00m[ 92%] �[32mapi/structtorch_1_1enumtype_1_1k_leaky_re_l_u .. api/structtorch_1_1nn_1_1_l1_loss_options�[39;49;00m
2022-06-20T16:49:45.3797788Z �[01mwriting output... �[39;49;00m[ 93%] �[32mapi/structtorch_1_1nn_1_1_l_p_pool_options .. api/structtorch_1_1optim_1_1_adagrad_options�[39;49;00m
2022-06-20T16:49:52.1145586Z �[01mwriting output... �[39;49;00m[ 95%] �[32mapi/structtorch_1_1optim_1_1_adagrad_param_state .. api/typedef_namespacetorch_1_1nn_1_1functional_1a98777e1591bd240b926382ee47c229b2�[39;49;00m
2022-06-20T16:50:04.4209941Z �[01mwriting output... �[39;49;00m[ 96%] �[32mapi/typedef_namespacetorch_1_1nn_1_1functional_1aa18646e3cd361617311b0c1d1743aa78 .. api/unabridged_api�[39;49;00m
2022-06-20T16:50:09.6959055Z �[01mwriting output... �[39;49;00m[ 98%] �[32mapi/unabridged_orphan .. installing�[39;49;00m
2022-06-20T16:50:09.9938478Z �[01mwriting output... �[39;49;00m[100%] �[32mlibrary .. notes/versioning�[39;49;00m
2022-06-20T16:50:09.9938858Z 
2022-06-20T16:50:10.0018512Z �[01mwaiting for workers...�[39;49;00m
2022-06-20T16:53:54.3546496Z /home/ec2-user/actions-runner/_work/_temp/e02500a4-099d-48cb-b26a-8eda75a442ef.sh: line 27: 15652 Killed                  docker exec -t "${container_name}" bash -c "sudo chown -R jenkins . && pip install dist/*.whl && ./.circleci/scripts/${DOCS_TYPE}_doc_push_script.sh"
2022-06-20T16:53:54.6877131Z ##[error]Process completed with exit code 137.
2022-06-20T16:53:54.7233951Z Prepare all required actions
2022-06-20T16:53:54.7304512Z ##[group]Run ./.github/actions/chown-workspace
2022-06-20T16:53:54.7304908Z ##[endgroup]
2022-06-20T16:53:54.7328202Z ##[group]Run docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
2022-06-20T16:53:54.7328850Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-06-20T16:53:54.8140311Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-06-20T16:53:54.8140721Z env:
2022-06-20T16:53:54.8141143Z   ALPINE_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine
2022-06-20T16:53:54.8141705Z ##[endgroup]
2022-06-20T16:53:55.3288020Z Unable to find image '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine:latest' locally
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.
8000

@aphedges
Copy link
Contributor Author

This PR is a follow-up to #74813 after 6c2e811 was reverted in e10cbe3 due to failing slow tests in trunk. According to #74813 (comment), I should add the label ciflow/trunk to this PR to make sure the regressions are fixed, but I don't have the permissions myself. @janeyx99, since you suggested the label, can you please add it yourself?

@kit1980, you reviewed and approved the previous PR, so it might make sense for you to review this one as well.

@kit1980 kit1980 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 20, 2022
@aphedges
Copy link
Contributor Author

I see a failure in https://github.com/pytorch/pytorch/runs/6969718439?check_suite_focus=true, but given that the test is for building the C++ docs and the job was killed by the CI system, I don't think it's related.

I'll continue following up with failures as jobs complete.

@janeyx99
Copy link
Contributor

@pytorchbot merge

@aphedges
Copy link
Contributor Author

I can see that all tests were successful, except for the one test that does not appear to be related.

@janeyx99, thanks for the approval!

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2531798655

@kit1980
Copy link
Contributor
kit1980 commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @aphedges.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@aphedges @facebook-github-bot
Fix code that triggers BytesWarning (#79868) (#79868)
4fd284e 
Summary:
Fixes #74812.

I have fixed the multiple instances in the repository that trigger
`BytesWarning`, and I have enabled the `-bb` option when tests are run
to prevent regressions.

Pull Request resolved: #79868
Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/cb2b7b1e57e965493e14f465de869a78f50967cb

Reviewed By: atalman

Differential Revision: D37311530

fbshipit-source-id: 44481090787499c9da268e7e84e5a53ccea285c3
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@aphedges @miladm
Fix code that triggers BytesWarning (pytorch#79868)
01b6d0b 
Fixes pytorch#74812.

I have fixed the multiple instances in the repository that trigger
`BytesWarning`, and I have enabled the `-bb` option when tests are run
to prevent regressions.
Pull Request resolved: pytorch#79868
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BytesWarning causes exception in torch.load() when running Python with -bb flag
6 participants
@aphedges @facebook-github-bot @janeyx99 @pytorchmergebot @kit1980 @pytorchbot
0