Support checkpoints #429
Support checkpoints #429
Conversation
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
Thanks Igor!
Yes, that is still pending, and it the only reason this PR is still in draft mode for this long. I'll add it soon and open it up for review :) |
Whoops, sorry I jumped the gun - the PR looked so nice and polished, calling to get reviewed |
Summary: ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Docs change / refactoring / dependency upgrade ## Motivation and Context / Related issue Ambiguous information about `alphas` and minor bugs in FAQ `privacy_engine` has no function `get_privacy_spent(delta)`, but it's `accountant` does. Also, the call requires delta to be passed as a named argument. There is no mention of `alphas` in the `privacy_engine` documentation, and I had to follow the code to figure it out. ## How Has This Been Tested (if it applies) N/A ## Checklist - [ ] The documentation is up-to-date with the changes I made. *N/A, no code changed* - [ ] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**). *I could not find any topic of 'CLA' in the **CONTRIBUTING** document* - [ ] All tests passed, and additional code has been covered with new tests. *N/A, no code changed* Pull Request resolved: pytorch#430 Reviewed By: ashkan-software Differential Revision: D36531555 Pulled By: karthikprasad fbshipit-source-id: 97ef2b309b657d0910769f10cf48fd5661004236
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@karthikprasad has updated the pull request. You must reimport the pull request before landing. |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Types of changes
Motivation and Context / Related issue
#373
How Has This Been Tested (if it applies)
Unit tests.
Checklist