Minor fixex in FAQ #430
Minor fixex in FAQ #430
Conversation
Added `accountant` in line 113. PrivacyEngine has no function `get_privacy_spent(delta)`. Also, the call requires delta to be passed as a named argument. Updated line 111 to note how a custom alpha list can be provided. There is no mention of `alphas` in the `privacy_engine` documentation, and I had to follow the code to figure it out.
fixed `delta=delta` in line 91
|
Hi @habedi77! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
CLA signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Docs change / refactoring / dependency upgrade ## Motivation and Context / Related issue Ambiguous information about `alphas` and minor bugs in FAQ `privacy_engine` has no function `get_privacy_spent(delta)`, but it's `accountant` does. Also, the call requires delta to be passed as a named argument. There is no mention of `alphas` in the `privacy_engine` documentation, and I had to follow the code to figure it out. ## How Has This Been Tested (if it applies) N/A ## Checklist - [ ] The documentation is up-to-date with the changes I made. *N/A, no code changed* - [ ] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**). *I could not find any topic of 'CLA' in the **CONTRIBUTING** document* - [ ] All tests passed, and additional code has been covered with new tests. *N/A, no code changed* Pull Request resolved: pytorch#430 Reviewed By: ashkan-software Differential Revision: D36531555 Pulled By: karthikprasad fbshipit-source-id: 97ef2b309b657d0910769f10cf48fd5661004236
Types of changes
Motivation and Context / Related issue
Ambiguous information about
alphasand minor bugs in FAQprivacy_enginehas no functionget_privacy_spent(delta), but it'saccountantdoes.Also, the call requires delta to be passed as a named argument.
There is no mention of
alphasin theprivacy_enginedocumentation, and I had to follow the code to figure it out.How Has This Been Tested (if it applies)
N/A
Checklist
N/A, no code changed
I could not find any topic of 'CLA' in the CONTRIBUTING document
N/A, no code changed