8000 scatter CI failures by apbose · Pull Request #2925 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

scatter CI failures #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions py/torch_tensorrt/dynamo/lowering/_decompositions.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gs-olive will there be fake tensor issue in this? The torch.compile test seems to be passing here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is within a decomposition, it should be fine since the torch.ones Tensor itself is never accessed or used

Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,10 @@ def slice_scatter_decomposition(
if i != dim:
index_tensor_shape.append(src_each_dim)
for index in range(start, end, step):
cat_tensors.append(index * torch.ones(index_tensor_shape, dtype=torch.long))
cat_tensors.append(index * torch.ones(index_tensor_shape, dtype=torch.int64))
index_tensor = torch.stack(cat_tensors, dim).cuda()
output_tensor = torch.scatter(input_tensor, dim, index_tensor, src_tensor)
index_tensor_64 = index_tensor.to(torch.int64)
output_tensor = torch.scatter(input_tensor, dim, index_tensor_64, src_tensor)
return output_tensor


Expand Down
Loading
0