8000 scatter CI failures by apbose · Pull Request #2925 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

scatter CI failures #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2024
Merged

scatter CI failures #2925

merged 2 commits into from
Jun 17, 2024

Conversation

apbose
Copy link
Collaborator
@apbose apbose commented Jun 15, 2024

]

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 15, 2024
@github-actions github-actions bot requested a review from gs-olive June 15, 2024 01:57
@apbose apbose marked this pull request as draft June 15, 2024 01:57
@apbose apbose removed the request for review from gs-olive June 15, 2024 01:58
@apbose apbose marked this pull request as ready for review June 17, 2024 16:03
@apbose apbose requested a review from gs-olive June 17, 2024 16:34
apbose
apbose commented Jun 17, 2024
View reviewed changes
py/torch_tensorrt/dynamo/lowering/_decompositions.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gs-olive will there be fake tensor issue in this? The torch.compile test seems to be passing here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is within a decomposition, it should be fine since the torch.ones Tensor itself is never accessed or used

gs-olive
gs-olive approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator
@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for the quick fix! Just pending 1 CI test case

@apbose apbose merged commit 5de2524 into main Jun 17, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apbose @gs-olive @facebook-github-bot
0